From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Using Emacs in fbterm. Date: Mon, 29 Aug 2022 20:33:13 +0300 Message-ID: <83czcjvtt2.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27190"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 29 19:34:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSieR-0006tT-79 for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 19:34:19 +0200 Original-Received: from localhost ([::1]:51016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSieO-0005N8-JD for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 13:34:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSid7-0003sC-Qq for emacs-devel@gnu.org; Mon, 29 Aug 2022 13:32:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSid6-0005JG-DK; Mon, 29 Aug 2022 13:32:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c2EHnpcgmioxYXAlD11WxfRQ/Ksb9dCcci0dHcODgMk=; b=seo2ITlawpYh WLPgNaqgNC1tCak8SUJPWL2yzWtpfe52jJkzKgHsxsvDcF78iRPwE36/z7kaA1ynBYJ6Hk0S6Ru+I FDKDcJ+RArE65D9vgFw2C+tInGVuFYqOIpfFn3eY6g8f7jhcq7oFMy1qFqoEDyu90LWM392z1atRc lUH/3nrFn7Mh2na7j6CxlRhJSMQZSjzn3Ws8jtZSxnAURH3+BAWVWHHNVgQAK3Wnz5pq80v8EsbBM NPvszcRrIgE+ECoJ//tK/ay559l7Cd3RsmLe9KpwHHnpeM/zgHxkXw+J6/A4qdSgSnVjFtMx/VwMt iOr6dCeEgqun74VzEC86Mw==; Original-Received: from [87.69.77.57] (port=3905 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSid2-0003Us-4D; Mon, 29 Aug 2022 13:32:56 -0400 In-Reply-To: (message from Alan Mackenzie on Mon, 29 Aug 2022 16:41:00 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294291 Archived-At: > Date: Mon, 29 Aug 2022 16:41:00 +0000 > From: Alan Mackenzie > > There is a problem with colours in Emacs in fbterm. When one does M-: > (defined-colors) it prints a list of just eight colours, black, red, > ...., white. > > However, the face constructing mechanism seems to assume more than eight > colours, and this seems buggy. Face constructing makes no such assumptions. If the colors defined for the face are not directly supported by the terminal (in this case, not in the 8 colors), Emacs uses color-translation to find the closest color that is supported. See tty-colors.el. If this translation doesn't produce satisfactory results, the face colors need to be either: . changed such that (a) on color-rich terminals the colors are similar, but (b) on 8-color terminals we get better results; or . the face definition should be changed to have a separate setting of colors for terminals with 8 colors > The face hi-green, for example, rather than having background > "green" gets "light green". This appears on the terminal as dark > yellow, which is clearly wrong. Why do you think it's wrong? Given that yellow is closer to hi-green (judging by its RGB components) than green, I see nothing wrong here. > Also the face mode-line-inactive is indistinguishable from the default > face ??? It should be the same as mode-line face of the active mode line. I wonder how come it's the same as the default in your case. Is that in "emacs -Q"?