From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type Date: Sat, 22 Oct 2022 09:45:59 +0300 Message-ID: <83czakuziw.fsf@gnu.org> References: <87v8orky2u.fsf@gnus.org> <20221021210636.13329-1-jonas@bernoul.li> <20221021210636.13329-2-jonas@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58363@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 09:06:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om8af-0003a0-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 09:06:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om8Hm-0001tL-Dq; Sat, 22 Oct 2022 02:47:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8Hh-0001t0-5e for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:47:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om8He-0007yz-4H for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1om8Hd-0000av-Ly for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 02:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 06:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.16664211912244 (code B ref 58363); Sat, 22 Oct 2022 06:47:01 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 22 Oct 2022 06:46:31 +0000 Original-Received: from localhost ([127.0.0.1]:39581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8H9-0000a8-En for submit@debbugs.gnu.org; Sat, 22 Oct 2022 02:46:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1om8H7-0000Zv-Mf for 58363@debbugs.gnu.org; Sat, 22 Oct 2022 02:46:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8H2-0007sX-1U; Sat, 22 Oct 2022 02:46:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E3EL0EiB3Z6lqHROUeKzhbPB4+HZW8A3I8y0lYzZPuk=; b=bJbt5CcXTD3J RF8PfFzGCqIYyhyn8Rvoc28bVuVzPo/nTxza+R+/tpgveiY2ZwY/bDCG78tG1+huB5ckaWPw0iVc5 dSSKpLadx+prxUQSZIbQs0CnjZHE1AOXc5M0rl2RSU+9bMlv/kho7BnD0viexMER2pvtktHwuVOyY 3oCe2ECr2f3YD9D8Wm29VpEy6Yg38u6uJqmA6Z6raE9H4KpxqIz7d6+gxotTyp26ReGaiDB2mCQpi NSW5PW328owILIiX0iv0yuM1mI+QeKUMfOPqMK7iZWZcMiPlWXcBzJEp7v6gEOjFzCqqZzyt+Oyg5 rHFa/zqFStOfEkA1Z9gpfA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om8Gd-00079Q-MZ; Sat, 22 Oct 2022 02:46:21 -0400 In-Reply-To: <20221021210636.13329-2-jonas@bernoul.li> (message from Jonas Bernoulli on Fri, 21 Oct 2022 23:06:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246024 Archived-At: > From: Jonas Bernoulli > Date: Fri, 21 Oct 2022 23:06:34 +0200 > > * src/sqlite.c (sqlite-load-extension): Use xsignal1. > --- > src/sqlite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/sqlite.c b/src/sqlite.c > index 1526e344e5..7861a699f4 100644 > --- a/src/sqlite.c > +++ b/src/sqlite.c > @@ -675,7 +675,7 @@ DEFUN ("sqlite-load-extension", Fsqlite_load_extension, > } > > if (!do_allow) > - xsignal (Qerror, build_string ("Module name not on allowlist")); > + xsignal1 (Qerror, build_string ("Module name not on allowlist")); Why Qerror here and not Qsqlite_error? And if the more general Qerror is deliberate, then why not Qmodule_load_failed, for instance?