From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Implementation direction for shell-script-mode with tree-sitter Date: Thu, 27 Oct 2022 09:06:39 +0300 Message-ID: <83czadn6kw.fsf@gnu.org> References: <87mt9j1k50.fsf@yahoo.com> <87tu3q6q8m.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jaopaulolc@gmail.com, emacs-devel@gnu.org, casouri@gmail.com, theo@thornhill.no To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 08:07:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onw3a-0006JA-6Y for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 08:07:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onw2s-0006KQ-2T; Thu, 27 Oct 2022 02:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onw2V-0005ZI-Md for emacs-devel@gnu.org; Thu, 27 Oct 2022 02:06:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onw2R-0006pP-4v; Thu, 27 Oct 2022 02:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xx9RUxduDGDc9RiNQGW0nrTs0jQJRhByEntzE0WwVM0=; b=XTLctrs/nq0o 3BoP/MsxfJWDlhlbDolK+ZXLX8l2z1GftYZTkqlfWpTYEpY3vibN2Fkj6YVKfx3yp6uMs11Pvm1To fnleAE4CJL7caYEf25bEsJn1r/9Io3+Kunvyh6dUD4b6o9kxA4gqve1zRYjhL+qTLq4T3Rw5e5eUw P5G2QzwPKFKekY+CN8U4PwEb7Ohymm6le760tEiFA4XILvWzmVH0lUKYJ+ezLYrU3RvHH57DqWl1s Sbi/bEWfwQq6RLQlNkbAj1JsSZKnz0ILlrhhVMQ6OXwpG4oR1w/ZqzSzu2p/Kf3ZjDhXyJQLCOqdw pR2F+bvhtHxegmodHzAcCQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onw2Q-00030F-G6; Thu, 27 Oct 2022 02:06:46 -0400 In-Reply-To: <87tu3q6q8m.fsf@yahoo.com> (message from Po Lu on Thu, 27 Oct 2022 08:54:01 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298603 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org, Yuan Fu , Theodor Thornhill > , Eli Zaretskii > Date: Thu, 27 Oct 2022 08:54:01 +0800 > > > My goal is to use the `sh-feature' function to retrieve everything > > that needs to be fontified for the buffer's shell variant. > > So won't you end up, in effect, reproducing the existing font-lock code? If that's so, I personally am not worried. >From where I stand, the single most important improvement from using tree-sitter in shell-mode buffers is to solve the problems with fontifications in tricky cases like here-documents etc. These are a source of constant stream of bug reports, when people expect us to do a decent job in those cases. I hope tree-sitter could solve that once and for all.