From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible Date: Wed, 09 Nov 2022 14:29:10 +0200 Message-ID: <83cz9wux9l.fsf@gnu.org> References: <871qqcdfvr.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19081"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59141@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 09 13:30:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oskDf-0004hN-Rr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Nov 2022 13:30:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oskDV-00066I-Ay; Wed, 09 Nov 2022 07:30:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oskDT-00063q-Vk for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 07:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oskDT-0000Qx-MX for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 07:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oskDS-0005Wm-I7 for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 07:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59141 X-GNU-PR-Package: emacs Original-Received: via spool by 59141-submit@debbugs.gnu.org id=B59141.166799696821133 (code B ref 59141); Wed, 09 Nov 2022 12:30:02 +0000 Original-Received: (at 59141) by debbugs.gnu.org; 9 Nov 2022 12:29:28 +0000 Original-Received: from localhost ([127.0.0.1]:39215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oskCu-0005Un-FH for submit@debbugs.gnu.org; Wed, 09 Nov 2022 07:29:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oskCs-0005Ub-ME for 59141@debbugs.gnu.org; Wed, 09 Nov 2022 07:29:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oskCn-0008AK-EB; Wed, 09 Nov 2022 07:29:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7iBpuf2QjiSlsKTYaKbwcMRuSYy1eJkIqyXegPLwBuE=; b=DO7GG3+uTDa4 S67aEfOJvezjg6U7lp1xz8II9jFbhTA9OPiEujsWhTAGRgXxZE4834LzMYobiUEPXeNm2DYR7/Eva sQVBqK3nQRWXEtznI14UQgZDvsWpHij43IaORR9n52ZcEcK2eZp7MCsb45YHe3Z359UW8rEHXSEw+ mkl4iqGAsHv90TYnK3RbzqmT1oQScEfWbUAUZeoY8Phz+WvBib2fxaJtRh/Cbp6UpzFMFO2MihBDG RkcXWzS9mBCqLWUpihTklwAsG1ZxegdyKCs3QMQdaS4bl/w9o5yLPqcGg9yf8umLfbKWPFxiXnjf2 LGaMEUjavxO5xa0ZmWsPFQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oskCi-0003GK-AE; Wed, 09 Nov 2022 07:29:20 -0500 In-Reply-To: <871qqcdfvr.fsf@localhost> (message from Ihor Radchenko on Wed, 09 Nov 2022 02:24:24 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247400 Archived-At: > From: Ihor Radchenko > Date: Wed, 09 Nov 2022 02:24:24 +0000 > > I do not see anything wrong on the Org side. Nothing wrong, no. But there's also nothing wrong with the Emacs behavior in this case: the last glyph on the "One" line has buffer position inside the region that has the org-block-end-line face. > Maybe Emacs should not apply :extent t attribute to the newline when the > text in fontified line is hidden? That'd be quite a complication. The code which implements the :extend attribute runs long after the invisible text was processed and skipped, leaving no glyphs on display. That code only knows what is the face at the buffer position that is the last on the screen line. So we'd need to go back and analyze the text which precedes the newline, and see whether any characters there are nowhere on display, which could be quite tricky, given the bidi reordering. Also, your proposal would disallow having the :extend face on the newline alone, I think. So I'd rather we didn't. I said many times that people shouldn't willy-nilly use the :extent attribute, just because it looks cooler in some situation. The intent was and still is for faces not to have this attribute set, with very few very special exceptions, like the 'region' face. But people don't listen...