From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: toml-ts-mode: first draft Date: Tue, 13 Dec 2022 15:20:16 +0200 Message-ID: <83cz8nphin.fsf@gnu.org> References: <4E261A68-AB14-48A5-B19C-8981CB003F33@secure.kjonigsen.net> <86a63unfvp.fsf@mail.linkov.net> <83cz8pu9cr.fsf@gnu.org> <0f74be1a-8502-ce66-6101-2b3f060295c5@secure.kjonigsen.net> <7825A406-3F21-4E38-9E9B-B429B9E81B4E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7753"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Rudolf Schlatte Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 13 14:20:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p55DG-0001oY-Gl for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Dec 2022 14:20:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p55Cy-0002O8-9a; Tue, 13 Dec 2022 08:20:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p55Cp-0002Iy-Pb for emacs-devel@gnu.org; Tue, 13 Dec 2022 08:20:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p55Cl-0003Xp-Fu; Tue, 13 Dec 2022 08:20:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7XfHnwqIuVDh2Vg5LIt/PzZPlzuqJYY9PJ6C/AN9si4=; b=YgbIsRje5bataJY1AKvq JXjzqoI+hEkXc6h/+C0LRK4QdFn6qPcue1V5fqeViXEYo4GAquwH5wajbB3msGDoTHdAP7jrr1g3Z 5SWC6Lu3PoFOicRfRMXVDqGAws+C3vncfFmyUMZ/qY9Or2kjidQSxmv4bdfNi1vo/P6a75T43EjuE XamvT81s3CP9FwGjn52BtGTBIXgU1t1oUZOkeL7rdcpRKiFRmsROed2jxV1bS+U0YY/0Vrr5CVc+Y WMQFaXAqk8dDLFTzQRxleg34UkrPr/9Au2j0R6Mg46do9hwF+8KvqJ74izs5dMQGEyssLmMoMhR1P jGLbG2sav8WTPw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p55Cd-00019n-Qy; Tue, 13 Dec 2022 08:20:17 -0500 In-Reply-To: (message from Rudolf Schlatte on Tue, 13 Dec 2022 11:45:42 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301312 Archived-At: > From: Rudolf Schlatte > Date: Tue, 13 Dec 2022 11:45:42 +0100 > > Yuan Fu writes: > > > > > + (unless (treesit-ready-p 'toml) > > + (error "Tree-sitter for TOML isn't avilable”)) > > > > Treesit-ready-p already raises a warning when something goes wrong. So > > you want to either pass the QUIET argument or let it do the barking > > ;-) > > I'd expect predicates (functions ending -p) to return T or NIL only and > not have side effects. Did you read the doc string of this function? I think it explains why this predicate can sometimes emit a warning and sometimes not. It has more than one modus operandi.