From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists Date: Thu, 12 Jan 2023 11:35:37 +0200 Message-ID: <83cz7kksd2.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60557@debbugs.gnu.org, joaotavora@gmail.com To: Evgeni Kolev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 10:36:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFu0b-0008BT-7G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 10:36:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFu0U-0004b9-UU; Thu, 12 Jan 2023 04:36:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFu0A-0004aP-Dx for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFu0A-0008M3-5c for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFu09-000748-QU for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 09:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60557-submit@debbugs.gnu.org id=B60557.167351611127094 (code B ref 60557); Thu, 12 Jan 2023 09:36:01 +0000 Original-Received: (at 60557) by debbugs.gnu.org; 12 Jan 2023 09:35:11 +0000 Original-Received: from localhost ([127.0.0.1]:44696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtzK-00072w-Ok for submit@debbugs.gnu.org; Thu, 12 Jan 2023 04:35:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtzJ-00072j-9X for 60557@debbugs.gnu.org; Thu, 12 Jan 2023 04:35:09 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtzD-0007sC-VE; Thu, 12 Jan 2023 04:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PeFbIUNIUP9oB205sz1QeDgiBFonzD37PMsB56foIeM=; b=rJ7jP/2oTD077MnIIta/ X8lBOxK9Tc45QwQb21iQwmPafDA7oJxcLzyeHVy3sfAObv/ZYicFj7nZ2vykIrV/e8duxlsfT/nZH q51yPSzD1M7c2tGAtkjAU3BvFSwd+uMkZTA523k5s38MTqbE5TeGgdFHQHCLnuJR8HhGfRIBisjht k9klLv+P2WIsXycc46IoLHg5+PEPk8mPkVig60TjVGxMusGwFPw+UrIDJXsuoRMqsIxvldf3HJMUj 7FF3GpTr3czqJSd/WtCHuJJxecA4N0WHgL7a6zOBIZTyAbzH0XSlGDJVkzTAqNxLJoYIHWQMOzUaX heQh//+7Su7gjg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtzC-0004nZ-UK; Thu, 12 Jan 2023 04:35:03 -0500 In-Reply-To: (message from Evgeni Kolev on Wed, 4 Jan 2023 17:44:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253197 Archived-At: > Cc: joaotavora@gmail.com > From: Evgeni Kolev > Date: Wed, 4 Jan 2023 17:44:27 +0200 > > [CC-ing João Távora, author of eglot] > > This patch fixes an incorrect behavior of eglot. To reproduce: > - run M-x eglot > - run M-x eglot (again) > - eglot now prompts whether to reconnect to the existing LSP > - enter "n" (for no) > - now eglot shuts down the LSP process and reconnects - this is not > correct, the expected behavior is to not reconnect > > The patch is below. João, any comments?