From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60954: 29.0.60; ERC 5.4.1: loading ERC clobbers customizations to erc-mode-hook Date: Fri, 20 Jan 2023 09:16:48 +0200 Message-ID: <83cz79oeu7.fsf__31565.3587853134$1674199053$gmane$org@gnu.org> References: <87pmb9wyz6.fsf@neverwas.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21994"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60954@debbugs.gnu.org, emacs-erc@gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 08:17:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIleO-0005U8-22 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 08:17:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIle7-0005Co-Fz; Fri, 20 Jan 2023 02:17:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIle2-0005A8-VZ for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 02:17:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIle2-0008Qz-L5 for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 02:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIle2-0008H7-BP for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 02:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60954-submit@debbugs.gnu.org id=B60954.167419901731792 (code B ref 60954); Fri, 20 Jan 2023 07:17:02 +0000 Original-Received: (at 60954) by debbugs.gnu.org; 20 Jan 2023 07:16:57 +0000 Original-Received: from localhost ([127.0.0.1]:45335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIldx-0008Gi-3F for submit@debbugs.gnu.org; Fri, 20 Jan 2023 02:16:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIldw-0008GU-3a for 60954@debbugs.gnu.org; Fri, 20 Jan 2023 02:16:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIldp-0008OR-0t; Fri, 20 Jan 2023 02:16:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RxHgT7S/QC2SaJKt0QSQ/B4bRYEYCUTDlTkEx96077E=; b=Oko2ALZOhWcl ko99uSe5Obu9sqz7/92yMRVFbGbv+o0C9vBuJJ0vbSJLdhe7EvNovjQDfzxocNOvVXZhD0TnxY9s+ PVXJPVha1iE10gmxPFHqPPcvdTuKmZ6lqomGvHOPl7F07ifAwZDHmgnyTzymkAD74gqAz5diNjI0q VfBScUKqvmuA/9wImcL5kp+GmAdce4fauk3oRqrjYnAdIEj/l8UXcIBhYU/ekGuU618Bh3DMTy13y bSeVSoodnC6D3MWq/iFFwpJAwgrAVY630vU95Z9zdSgylVlDSAb7V/k75zsiuhxHvM0rmsi4s3nwM lLmGSr8nJlhfk5lNLxswyg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIldo-0000mQ-Fg; Fri, 20 Jan 2023 02:16:48 -0500 In-Reply-To: <87pmb9wyz6.fsf@neverwas.me> (jp@neverwas.me) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253752 Archived-At: > Cc: emacs-erc@gnu.org > From: "J.P." > Date: Thu, 19 Jan 2023 21:34:37 -0800 > > I see two basic avenues of attack here. The first is a pretty safe > stopgap and the second a slightly riskier comprehensive approach that > should have been on the books the moment that bug was closed: > > hack: partially revert a tiny hunk from the commit above > > fix: don't require goodies at all and instead update the module > mapping data and add all necessary autoloads and forward > declarations > > Implementations of both are attached. (I didn't bother updating the > required Compat version in the second patch, but that'd also need to > accompany the change set.) For now, I propose we take the shorter route > but with an eye toward revisiting the issue soon after the next (ERC) > release. If anyone has an opinion here, now would be the time to speak > up. Your proposal is fine with me, thanks.