From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Fri, 17 Feb 2023 16:17:15 +0200 Message-ID: <83cz681ims.fsf@gnu.org> References: <837cx8cey0.fsf@gnu.org> <83357irhnv.fsf@gnu.org> <87ttzy2lgi.fsf@X570GP> <83a61pprm8.fsf@gnu.org> <87mt5ncjuk.fsf@X570GP> <83cz6jm9mo.fsf@gnu.org> <87a61lkjb7.fsf@X570GP> <87pmahs9um.fsf@EBx360> <877cwoo6ru.fsf@X570GP> <83bkm0jxbr.fsf@gnu.org> <87ttzq25m6.fsf@X570GP> <837cwmhlgs.fsf@gnu.org> <87pmae1wrs.fsf@X570GP> <83v8k6fxy5.fsf@gnu.org> <87y1p01qlc.fsf@EBx360> <83y1p0cq3v.fsf@gnu.org> <877cwiblk8.fsf@X570GP> <83leky828x.fsf@gnu.org> <83r0uo1zdx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40698"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, larsi@gnus.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 17 15:18:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT1Yp-000ANt-9Q for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Feb 2023 15:18:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pT1Y6-0003k5-Pd; Fri, 17 Feb 2023 09:17:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT1Y4-0003js-GS for emacs-devel@gnu.org; Fri, 17 Feb 2023 09:17:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT1Y4-00056d-0W; Fri, 17 Feb 2023 09:17:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LN0JK5XaXDjxZcNt+kF/xzA2BZ+6Cic03JI4YDEls1c=; b=TVFebZVPJGel vBvuKiwfyXNqCoMfT085iz/WESzUK96IwilYbMHLx2C6/PXTdg4Pi5KJQA/vzUyFOAY7m4iqzSjbK cVanlIh/IFAJpVZ4Vx0So/OptresLCE07FfUXuqyap+MEwiW0LnB6gHwlIliV/pXcbsU9t/y7dF9X yuBdyt46bXd+2zOWCdOukzIWyHCL1Lf47IyMM5PTY42zKHKllj62Vl2o8WOinpMygQnQI4TZz1xMO JciaQF0fFsvvvd3ZvqSDNj+gve+FVIbeHwgb9hCbX2LQt5MCzM3gagMx56TexpIK9niIrTW5MbC63 MU7z0PFkKFQckFIUqsAMEg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT1Y3-0001mv-GV; Fri, 17 Feb 2023 09:17:15 -0500 In-Reply-To: (message from Andrea Corallo on Fri, 17 Feb 2023 10:16:38 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303485 Archived-At: > From: Andrea Corallo > Cc: aymeric.agon@yandex.com, spwhitton@spwhitton.name, > monnier@iro.umontreal.ca, emacs-devel@gnu.org, larsi@gnus.org, > rlb@defaultvalue.org > Date: Fri, 17 Feb 2023 10:16:38 +0000 > > Eli Zaretskii writes: > > > Andrea, I think you can now merge this branch to emacs-29 when you > > have time, and let's take it from there. > > > > Thanks. > > Done now with d6e4f243720. Thanks. I've installed a few updates to the docs, please take a look and tell me if I made any mistakes. I have a question about this code from comp.el: (defun comp--trampoline-abs-filename (subr-name) "Return the absolute filename for a trampoline for SUBR-NAME." (cl-loop with dirs = (if (stringp native-comp-enable-subr-trampolines) (list native-comp-enable-subr-trampolines) (if native-compile-target-directory (list (expand-file-name comp-native-version-dir native-compile-target-directory)) (comp-eln-load-path-eff))) with rel-filename = (comp-trampoline-filename subr-name) for dir in dirs for abs-filename = (expand-file-name rel-filename dir) unless (file-exists-p dir) do (ignore-errors (make-directory dir t) (cl-return abs-filename)) when (file-writable-p abs-filename) do (cl-return abs-filename) ;; Default to some temporary directory if no better option was ;; found. finally (cl-return (expand-file-name (make-temp-file-internal (file-name-sans-extension rel-filename) 0 ".eln" nil) temporary-file-directory)))) This seems to use native-comp-enable-subr-trampolines, if it is a string, without expanding it relative to anything, which AFAIU means it will be interpreted relative to the current buffer's default-directory. Is that indeed so, and if so, should we perhaps interpret it relative to invocation-directory, like we do with native-comp-eln-load-path? Because which buffer is current when trampoline compilation happens is anyone's guess, especially if that happens in a sub-process. Thanks.