From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Sun, 26 Mar 2023 07:19:12 +0300 Message-ID: <83cz4wb0vz.fsf@gnu.org> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 06:20:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgHrZ-0009CP-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 06:20:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgHrS-0002cf-Jt; Sun, 26 Mar 2023 00:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgHrQ-0002cA-0E for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgHrP-0004HT-0Z for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgHrO-0007sa-He for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167980436230237 (code B ref 62427); Sun, 26 Mar 2023 04:20:02 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 26 Mar 2023 04:19:22 +0000 Original-Received: from localhost ([127.0.0.1]:43784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgHqj-0007rd-Ub for submit@debbugs.gnu.org; Sun, 26 Mar 2023 00:19:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgHqi-0007rR-4Y for 62427@debbugs.gnu.org; Sun, 26 Mar 2023 00:19:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgHqb-0004Cy-P4; Sun, 26 Mar 2023 00:19:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jVKe6uUhyxgM9FLlEnIA33/cYWOnk5G0k60QmzgVoYY=; b=BoFdVVKgRWh1 zAWe0ODmpdekYBewpmqFWPa9PfdVwk7j6PYX9I3wY4IPWLXhcuBEb48jI73j/WJVbfaD/9jlg+RzM CMe27WTn+fmIJtb/4fKKPQ69RKFQqJQ4SQB4FKj8DcsdjxThn0BCEBPs0b0TZz6zbNxcp4GRIqKFH vguw+ai9Rva2pA0sfiLj71fMypX47ZI5Rgd36upR0NyrTLPeVLSUDVWPaGS2qOQxcJU+HBIhYCD+U WQZtF+AFOztAVC/g+UM6WkhZHEFQ/KsMhzXklyX3fCgGjVzuSEisaTb6EsMkj+HPnUa9DkaXgKE32 MVg3Kw6gpSJpCi5ka30Pbw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgHqa-0003zd-Rk; Sun, 26 Mar 2023 00:19:13 -0400 In-Reply-To: <86jzz4mynj.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 25 Mar 2023 21:14:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258644 Archived-At: > Cc: 62427@debbugs.gnu.org > From: Juri Linkov > Date: Sat, 25 Mar 2023 21:14:24 +0200 > > > I've noticed that when I call #'tab-bar-new-tab while I'm in a > > side-window that has siblings, I get an error from > > #'window--sides-check, which happens when #'tab-bar-new-tab calls > > #'delete-other-windows. Here's an example of my problem: > > ... > > The attached patch fixes this issue. Could it be applied to the emacs-29 > > branch? > > Thanks. Unless Eli has objections, I'd like to push the patch > to the emacs-29 branch since it correctly fixes the problem. I'd like first to understand better the code involved and the suggested change in it. Just reading the code of tab-bar-new-tab-to, it looks strange. Why does tab-bar.el care about "window parameters that can cause problems with 'delete-other-windows' and 'split-window'" to begin with? And why removing these parameters from windows is TRT for tab-bar.el to resolve such problems, when it doesn't really "own" those windows? (Also, the patch's commit log message is not according to our conventions, but that's a minor issue.)