From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Mon, 27 Mar 2023 16:36:50 +0300 Message-ID: <83cz4u9uz1.fsf@gnu.org> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23148"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 15:37:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgn25-0005lW-SU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 15:37:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgn21-0006KW-OX; Mon, 27 Mar 2023 09:37:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgn1z-0006D0-Dh for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgn1y-0007BG-2D for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgn1x-0005wO-Uv for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167992421522821 (code B ref 62427); Mon, 27 Mar 2023 13:37:01 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 13:36:55 +0000 Original-Received: from localhost ([127.0.0.1]:46841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgn1q-0005w0-Vr for submit@debbugs.gnu.org; Mon, 27 Mar 2023 09:36:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgn1p-0005vl-HM for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 09:36:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgn1j-00079H-KA; Mon, 27 Mar 2023 09:36:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FpSDMVSqdyDmFmqwUq2mbJhH04kGfHZwRc4RlDu1ZuM=; b=JM4luXWzSbR9 vQqr/Tc0WNbuZvZrElJXeVLP0wSvmKjXrcipRJpnQxNPl4+MBJ9t5jUY2dZKcAYd3Sug4tlYbiqMd 4vaUskjMmdV288OLgnCXZFEJMrgABha9JQP9DQ1ih60JHP+wODI3K6RTPIiIxR3t5AxkpYmaUih7C n6B6Z5afTzgnWeyFcW6AC8s3yTzOTc0f3JApklrIjX42BFVAhAWxtf8KvSMff8m1iMwdADV3ZMsfX YDcUaj1J8d981HIkSDKtae63pF3h4APJD2Fh7XINe9B20zSRB0Wb9Uy+EjA3G3a/dpf7XaWxfMWUu ybe66IOAl5dXBAzyoc/Jrg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgn1i-0003Yt-TI; Mon, 27 Mar 2023 09:36:47 -0400 In-Reply-To: <865yamhdx7.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 27 Mar 2023 10:05:40 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258729 Archived-At: > From: Juri Linkov > Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org > Date: Mon, 27 Mar 2023 10:05:40 +0300 > > >> > I've noticed that when I call #'tab-bar-new-tab while I'm in a > >> > side-window that has siblings, I get an error from > >> > #'window--sides-check, which happens when #'tab-bar-new-tab calls > >> > #'delete-other-windows. Here's an example of my problem: > >> > ... > >> > The attached patch fixes this issue. Could it be applied to the emacs-29 > >> > branch? > >> > >> Thanks. Unless Eli has objections, I'd like to push the patch > >> to the emacs-29 branch since it correctly fixes the problem. > > > > I'd like first to understand better the code involved and the > > suggested change in it. Just reading the code of tab-bar-new-tab-to, > > it looks strange. Why does tab-bar.el care about "window parameters > > that can cause problems with 'delete-other-windows' and > > 'split-window'" to begin with? And why removing these parameters from > > windows is TRT for tab-bar.el to resolve such problems, when it > > doesn't really "own" those windows? > > Indeed, maybe 'delete-other-windows' and `split-window' > should handle these cases. So since the patch fixes the bug, > it could be pushed to emacs-29. Then in master > 'delete-other-windows' and `split-window' could be rewritten > to handle the 'window-side' parameter. Maybe I'll agree, but I still don't understand the problem well enough. Would you please explain the original problem that led tab-bar.el to care about these window parameters? TIA