From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62413: 29.0.60; [PATCH] save-place-mode cannot restore saved position Date: Tue, 28 Mar 2023 15:03:20 +0300 Message-ID: <83cz4t84mv.fsf@gnu.org> References: <83tty9caku.fsf@gnu.org> <83y1nkc3vc.fsf@gnu.org> <83zg809jgv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62413@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 28 14:04:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ph847-0002CX-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Mar 2023 14:04:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ph83Z-0006z4-Ki; Tue, 28 Mar 2023 08:04:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph83X-0006yr-68 for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 08:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ph83W-0000Nj-G0 for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 08:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ph83V-0006tb-U0 for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 08:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62413-submit@debbugs.gnu.org id=B62413.168000500326453 (code B ref 62413); Tue, 28 Mar 2023 12:04:01 +0000 Original-Received: (at 62413) by debbugs.gnu.org; 28 Mar 2023 12:03:23 +0000 Original-Received: from localhost ([127.0.0.1]:49103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph82s-0006sb-TK for submit@debbugs.gnu.org; Tue, 28 Mar 2023 08:03:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph82r-0006sM-M0 for 62413@debbugs.gnu.org; Tue, 28 Mar 2023 08:03:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph82l-0000Id-U3; Tue, 28 Mar 2023 08:03:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UYMCJEqQSoOl4/+u346yGX2k5C2JlS7o30XHb3xOLsE=; b=jkyumtWo5MEK8e9tvJyI eKX4FAJH9tUuwZsdTFJmIS8tfwpBBPHDRQjKnTA7MxUv6r0+P34ZFQdHKRLoDzWg4g6XCsSg/MSnY 9Rk2RufHlA6cTP1DjQXUQYiemB6DVkPUnPLHakSqt3b0qQxN46KS02lHxwwIzGQzvtWyW7inl81Hn /3QN9iEvil4dzrqa3s+opQr5E5nOTd7eA5Yl2ekpnVz0ejWj/55Lx/iY7aypKJRorVsYu9XgSV/P0 5CRwLYTIeBgmSbIaYX7uIf+Y0UwudNMSVOhVrs90tW+H1AxWaqsJ0cksSIcvywM+gf6K4ohs+VVHR 6mwuLaCC0Gp7bA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph82l-0004Rb-CD; Tue, 28 Mar 2023 08:03:15 -0400 In-Reply-To: (message from Liu Hui on Tue, 28 Mar 2023 13:56:05 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258799 Archived-At: > From: Liu Hui > Date: Tue, 28 Mar 2023 13:56:05 +0800 > Cc: 62413@debbugs.gnu.org > > Eli Zaretskii 于2023年3月26日周日 13:20写道： > > > Ugh! This feature was not thought out well enough when it was > > introduced: if the user changes the value half-way through a session, > > the history will record visited files twice, under 2 different > > file-name formats and with different places recorded. I think > > changing the value of save-place-abbreviate-file-names should rewrite > > the entire alist in the selected format. > > I agree that it is better to avoid mixed file name formats, and then > save-place-find-file-hook can be fixed simply. The difficult part is > how to rewrite save-place-alist automatically. Isn't it just a matter of going through the list and calling abbreviate-file-name on each file name there?