From: Eli Zaretskii <eliz@gnu.org>
To: Thuna <thuna.cing@gmail.com>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 62959@debbugs.gnu.org
Subject: bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions
Date: Thu, 20 Apr 2023 09:50:46 +0300 [thread overview]
Message-ID: <83cz3z6o8p.fsf@gnu.org> (raw)
In-Reply-To: <87o7njv7qh.fsf@gmail.com> (message from Thuna on Thu, 20 Apr 2023 00:15:50 +0200)
> From: Thuna <thuna.cing@gmail.com>
> Date: Thu, 20 Apr 2023 00:15:50 +0200
>
> The function `eieio--known-slot-name-p' is used by some eieio functions
> (specifically eieio-oref, eieio-oref-default, and eieio-oset-default) to
> check whether a slot name is known or not, and if not signals an
> "Unknown slot" warning.
>
> Structs do not make their slots known to `eieio--known-slot-name-p', so
> the warning is signaled even for valid slot names. Since eieio aims for
> compatibility with defstruct, this should probably be considered a bug.
>
> The function `eieio--known-slot-name-p' checks the variable
> `eieio--known-slot-names' but also has a fallback for the name's
> `slot-name' property. In the patch I opted to use the latter.
>
>
> >From 86ed1ed7d024a0d40286d5fe4697258dc98a1b9e Mon Sep 17 00:00:00 2001
> From: Thuna <thuna.cing@gmail.com>
> Date: Wed, 19 Apr 2023 23:43:22 +0200
> Subject: [PATCH] Recognize defstruct slot names in various eieio functions
>
> * lisp/emacs-lisp/cl-preloaded.el (cl-struct-define): Set each slot's
> name's `slot-name' property so that `eieio--known-slot-name-p' can
> recognize them.
> ---
> lisp/emacs-lisp/cl-preloaded.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el
> index 9445093f143..5235be52996 100644
> --- a/lisp/emacs-lisp/cl-preloaded.el
> +++ b/lisp/emacs-lisp/cl-preloaded.el
> @@ -176,6 +176,7 @@ cl-struct-define
> (i 0)
> (offset (if type 0 1)))
> (dolist (slot slots)
> + (put (car slot) 'slot-name t)
> (let* ((props (cl--plist-to-alist (cddr slot)))
> (typep (assq :type props))
> (type (if (null typep) t
> --
> 2.39.2
>
Stefan, any comments?
next prev parent reply other threads:[~2023-04-20 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 22:15 bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions Thuna
2023-04-20 6:50 ` Eli Zaretskii [this message]
2023-05-02 20:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-03 11:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cz3z6o8p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62959@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=thuna.cing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.