From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dict Date: Sat, 20 May 2023 17:19:57 +0300 Message-ID: <83cz2vrsoi.fsf@gnu.org> References: <834joj55pt.fsf@gnu.org> <87ednnvtt6.fsf@posteo.net> <875y8ywwko.fsf@posteo.net> <83zg69br5f.fsf@gnu.org> <83ednj9sw2.fsf@gnu.org> <837ct5x5v6.fsf@gnu.org> <83sfbtvii4.fsf@gnu.org> <83h6s9vdft.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23613"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 20 16:20:11 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0NRL-0005xu-Mq for ged-emacs-devel@m.gmane-mx.org; Sat, 20 May 2023 16:20:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0NQs-00087b-3n; Sat, 20 May 2023 10:19:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0NQq-00087R-T0 for emacs-devel@gnu.org; Sat, 20 May 2023 10:19:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0NQq-00047C-Es; Sat, 20 May 2023 10:19:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nD7nFEk/dgy8VgRji7ktsbLS7J4nnDWLsBwOqPLN3CY=; b=dQGiuF+kfmu8 Uzmyv9U92C9FhjiYjZEvD62ptZEIbw8WGMzaxTM3Fsfstxu1D8Ovr7UEwstws2ibCx39l66H+HPGO 32VfBiyOk1dobfjjIIq7OgsD9MBMWMOloAmAq4678TTy9g1vBIpkD0u0kXowQD9crYDDgbht5OVY7 SmnVqD6iGwAUEX2KJCUIOYGA18joj1nm/tikp3yqRDrfmFZcuJQ7kLPSA4rSVls9lfl+9pl53cCY9 RqapUGyGCmiwP+vvhKCDcXlt1VR+LkfEeBg+kZ2xGxw2BQjxRZdaT2LuQUf631miP/TaBCrg5nfvw Qo8wuE6eodBpgdvauqvlrw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0NQp-0007z7-VD; Sat, 20 May 2023 10:19:40 -0400 In-Reply-To: (message from Eshel Yaron on Fri, 19 May 2023 11:34:12 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306233 Archived-At: > From: Eshel Yaron > Cc: philipk@posteo.net, emacs-devel@gnu.org > Date: Fri, 19 May 2023 11:34:12 +0300 > > Eli Zaretskii writes: > > > AFAIR, this started from you proposing a package that would behave as > > if all 3 options were customized, and saying that you like this > > alternative behavior much better, so much so that you felt a new > > package is in order. So I'm asking why not let users who, like you, > > will like that much better, to get that behavior, with all its bells > > and whistles, by setting just one option? Wouldn't you personally > > like such an option and use it all the time? > > Yes, I see what you mean. I'm attaching an updated patch that > implements your suggestion to add another `defcustom` with an > appropriate :set function. It's now enough to do: > > --8<---------------cut here---------------start------------->8--- > (setopt dictionary-search-interface 'help) > --8<---------------cut here---------------end--------------->8--- > > The updated patch also tries to address Philip's recommendation to > extract the default parts of `dictionary-search` to standalone > functions. Thanks, LGTM. Let's wait for a few days to let others to chime in with comments.