From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 16:25:29 +0300 Message-ID: <83cz20yfqu.fsf@gnu.org> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19977"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: michael.albinus@gmx.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 15:26:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8hYx-0004sd-9n for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 15:26:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8hY9-0004z4-GV; Mon, 12 Jun 2023 09:25:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8hY1-0004yh-8x for emacs-devel@gnu.org; Mon, 12 Jun 2023 09:25:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8hY0-0003Be-B2; Mon, 12 Jun 2023 09:25:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o8XLG5WTmzWhF0J46u5+SV1+WMGEaswIXln4FSXrlO0=; b=bIIrdJ5Vjc/e m/0Ccm2fnogahQHGWK5RHQ8bdJROTTRqYUeshScIbdFWApLWVOO8jkIZdG/pysslw29U0gFQpXClN L6vS0nHK+PzzVAssmbl/d9eE6OhLNf5MBZ4i8tOeeWzJ5uAPX0sRYOIFKZ6QqcNJro8kIlCRv6VHx f3q7VhoKL5qqHIX0SmgIy3eihpArmgAtUuRVvwBMqUn369IHp4Bp61WYZaX2DiUlsp3l6lk/oCWyP p1Oj3mXi5ribFXT4VgFfWAAhRZ46Zcz75hmObU/2penvdKv3Ei2cR1X3pFASYrygIsmgNc7fpu3fR 67QrsHDINvau41dlm/Y1jw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8hXm-00042h-Qv; Mon, 12 Jun 2023 09:25:27 -0400 In-Reply-To: <83edmgygew.fsf@gnu.org> (message from Eli Zaretskii on Mon, 12 Jun 2023 16:11:03 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306748 Archived-At: > Date: Mon, 12 Jun 2023 16:11:03 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > Sorry, I have no idea what this failure means. In particular, the > value is correct for the defcustom, and works in practice, and also > fits the type of the defcustom (AFAICT). > > The checks that cus-test.el does are not documented in any meaningful > way, and its output is not useful. I didn't even know we had such a > test, and never ran it myself. Btw, running "make test-custom-opts" in test/ gives me a different error: make[1]: Entering directory `/d/gnu/git/emacs/branch/test' Running 1 tests (2023-06-12 16:19:27+0300, selector `(not (or (tag :unstable) (tag :nativecomp)))') Loading d:/gnu/git/emacs/branch/admin/cus-test.el (source)... Running cus-test-load-libs Finding files... Test check-for-wrong-custom-opts backtrace: signal(error ("find exited with status 1")) apply(signal (error ("find exited with status 1"))) (setq value-7 (apply fn-5 args-6)) (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-descri (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de (let (form-description-9) (if (unwind-protect (setq value-7 (apply f (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti (let* ((fn-5 #'null) (args-6 (condition-case err (let ((signal-hook- (closure (t) nil (let* ((fn-0 #'file-readable-p) (args-1 (condition- ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name check-for-wrong-custom-opts :document ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :unstabl ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "misc/test-custom-opts.el" command-line() normal-top-level() Test check-for-wrong-custom-opts condition: (error "find exited with status 1") FAILED 1/1 check-for-wrong-custom-opts (0.406250 sec) at misc/test-custom-opts.el:33 Ran 1 tests, 0 results as expected, 1 unexpected (2023-06-12 16:19:28+0300, 1.453125 sec) 1 unexpected results: FAILED check-for-wrong-custom-opts So there's more to this than meets the eye, and some code (but which one?) which runs 'find' is probably doing that in a non-portable fashion. (I needed to run admin/cus-tests.el by hand to get the error which you quote.)