From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64406: [PATCH] Improve commands to manage Python imports Date: Thu, 13 Jul 2023 09:07:34 +0300 Message-ID: <83cz0w5opl.fsf@gnu.org> References: <874jmnbd5v.fsf@gmail.com> <87pm534puk.fsf@gmail.com> <87lefr399j.fsf@gmail.com> <87bkgl39bm.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40181"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arstoffel@gmail.com, 64406@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 08:08:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJpVL-000AGq-Td for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 08:08:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJpV0-0005Z1-5E; Thu, 13 Jul 2023 02:08:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJpUk-0005Ya-NN for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 02:08:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJpUh-0003bo-8z for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 02:08:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJpUf-0007cH-O3 for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 02:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 06:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64406-submit@debbugs.gnu.org id=B64406.168922845029237 (code B ref 64406); Thu, 13 Jul 2023 06:08:01 +0000 Original-Received: (at 64406) by debbugs.gnu.org; 13 Jul 2023 06:07:30 +0000 Original-Received: from localhost ([127.0.0.1]:53203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJpU9-0007bU-LO for submit@debbugs.gnu.org; Thu, 13 Jul 2023 02:07:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJpU7-0007bI-VN for 64406@debbugs.gnu.org; Thu, 13 Jul 2023 02:07:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJpU1-0002Cg-2Z; Thu, 13 Jul 2023 02:07:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WFuYfREME+E6+NlfHWoFwE5Cd2O4N402r7Xm5U6YVHU=; b=dXRwGX/sBHV/ s5dVFOX0cOnAlX70+kpW2HkEDv41TFzBzPAh2ojA3y3OcDfvGk9/6vNKRRLLHtCOYCrIMM0BLlLG+ oI6ntVVNGHXdNJJMG7waAQXoMIeTTET1dD9bzJGEbWHrdzq4ow3UzU5pfpaL0aYhGVAS8CSwvmAxp F0olsp5OKl/ArCEH1JDQfMneHFza3Hqh683QAd7SatM6pJI5fL7/E95uZV6U9v2+CW+tXnR9jpi2L ZFY3r8d9uiR8speZDFH8V07vfb06kvrhP8D7PvwwMjRfm64djDIZpWd5qoCVrk+m0UYnYh6gXj3Qd /n7+IsG0zejSadm5RaLYRA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJpTz-00015i-W5; Thu, 13 Jul 2023 02:07:20 -0400 In-Reply-To: <87bkgl39bm.fsf@gmail.com> (message from Matthias Meulien on Sun, 09 Jul 2023 08:09:17 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265001 Archived-At: > Cc: 64406@debbugs.gnu.org > From: Matthias Meulien > Date: Sun, 09 Jul 2023 08:09:17 +0200 > > Here are two patches. > > The first one revert part of the original patch where I introduced a > useless detailed check of isort exit status itself. > > The second one relates to your remarks: It shift the custom exit status > of the Python script and make sure that an error is reported assoon as > exit code >0. Thanks. Could you please make a single patch from these two? There's no need to revert the original one in a separate patch. > Subject: [PATCH 1/2] Fix "Improve Python imports management commands" > > * lisp/progmodes/python.el (python--do-isort): The isort library don't > check for its version itself! I don't think I understand this log entry. What does it mean "the isort library don't check its version"? > + ((eq 3 status) " (maybe isort version is less than 5.7.0?)") ^^^^^^^ Here, "is older" should be more clear, I think.