From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64535: 30.0.50; Spurious newlines in `prin1` output Date: Fri, 14 Jul 2023 16:38:08 +0300 Message-ID: <83cz0ufwan.fsf@gnu.org> References: <83v8etbrhe.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64535@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 15:39:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKJ0w-0001ay-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 15:39:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKJ0k-0006nG-35; Fri, 14 Jul 2023 09:39:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKJ0i-0006ms-7v for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 09:39:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKJ0g-00062L-G5 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 09:39:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKJ0g-00012i-B9 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64535 X-GNU-PR-Package: emacs Original-Received: via spool by 64535-submit@debbugs.gnu.org id=B64535.16893418833921 (code B ref 64535); Fri, 14 Jul 2023 13:39:02 +0000 Original-Received: (at 64535) by debbugs.gnu.org; 14 Jul 2023 13:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:41733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKIzj-00011B-4G for submit@debbugs.gnu.org; Fri, 14 Jul 2023 09:38:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKIze-000101-0Y for 64535@debbugs.gnu.org; Fri, 14 Jul 2023 09:37:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKIzX-0004UU-F5; Fri, 14 Jul 2023 09:37:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iq+bRgfa9LXXR4biUfduKtP6Koe4oxRiLP11ZS2VmO8=; b=kxJi0XNr4wsj JJYY/ttZ34CWhS77/3UmNAaJeTRHVUMFijktBAsloRojaMu6qcxdjALYOvh5hnabDqqRJ8hLYGxJz doc+DGubNFKEsQ1YQF9fASq0oejZnvi6s4Sf8v69K8uQKHG125mR3TbmqfjLGdstWj6obllrA0vBo dFmWVdimAAeZG7+5aMOFqsAn4rLsNUty3wr6IfRdcUyq/wrUYFFjDZVwk5I7KeoIAMjICRNokh9VM xZ7AIa0j+ax1atbyJE702dswVcywyxKzuHJ2JvJg4yFiko3ObHSWVKnjoPAS2G1l7L5jZxVL+LiAm h6sC5UEo63/Px9dNJXWTpQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKIzW-0006j2-Ro; Fri, 14 Jul 2023 09:37:51 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 13 Jul 2023 19:11:48 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265090 Archived-At: > From: Stefan Monnier > Cc: 64535-done@debbugs.gnu.org > Date: Thu, 13 Jul 2023 19:11:48 -0400 > > >> Can we get rid of this quirk now, please? > > > > I'm okay with getting rid of it, with two conditions: > > > > . removing newline insertion in the scenario of bug#2866 leaves > > Emacs sufficiently performant, even in the unoptimized build, and > > . we will still insert a newline if long-line-threshold is nil > > That means we'd keep the code and make it even larger. The second item, maybe. What about the first -- is bug#2866 solved by long-line handling in Emacs 29? > > IOW, I don't want us to bring back regressions as result of > > this cleanup. > > That wouldn't be a cleanup, then. IOW you're asking me to make the > quirk even bigger. I'd rather keep the quirk as-is, in that case. Sorry, I don't understand: what was the reason for you to start this discussion? IOW, why is it good to get rid of the code which inserts those newlines? I don't suppose you wanted to bring back the bug which was the reason for adding that code, did you? I can suggest another solution: remove that code, but make sure long-line-threshold is reset to its default value locally in the buffer where prin1 is producing its output? Would that be more acceptable?