From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Date: Wed, 26 Jul 2023 18:18:25 +0300 Message-ID: <83cz0eog5a.fsf@gnu.org> References: <87bkgfjugn.fsf@catern.com> <83edlb3t0t.fsf@gnu.org> <22ee6190-5946-9bde-b648-a55dd2188576@gutov.dev> <83mszt7a1a.fsf@gnu.org> <5c266c9b-a719-41d9-327e-6a2152adaffe@gutov.dev> <838rbc5c8v.fsf@gnu.org> <83v8eg3ue7.fsf@gnu.org> <83a5vpbaa6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23831"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 26 20:20:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOj7Y-0005zg-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jul 2023 20:20:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOiDj-0000rb-JA; Wed, 26 Jul 2023 13:22:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOgH5-0005pL-37 for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 11:18:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOgH4-0002gX-Rs for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 11:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOgH4-0003Tl-0O for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2023 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62621 X-GNU-PR-Package: emacs Original-Received: via spool by 62621-submit@debbugs.gnu.org id=B62621.169038466813341 (code B ref 62621); Wed, 26 Jul 2023 15:18:01 +0000 Original-Received: (at 62621) by debbugs.gnu.org; 26 Jul 2023 15:17:48 +0000 Original-Received: from localhost ([127.0.0.1]:49856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOgGp-0003T7-HT for submit@debbugs.gnu.org; Wed, 26 Jul 2023 11:17:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOgGn-0003Sv-O7 for 62621@debbugs.gnu.org; Wed, 26 Jul 2023 11:17:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOgGh-0002e0-Mw; Wed, 26 Jul 2023 11:17:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kPBY5D2kGX3H3P0nQxnXY3vkvMWRw/B/xZJIat6czF8=; b=M/znbAJN5VcC k+j488KANsxmofjabQUQZTMDDc1FibLH/U1zTaOmSTwsPEgczjPVWCACV3OH/zZ04kFBznDM3/3V4 jCMYtBaKEmPx6wjX6PDpZhg5+i9bAo3xpQk7RlpkqE/r0+WMDtKknUZ6U4tVOOBTPzEQjfZYa6xJP +/VpZD5UhFwrb8hwbIeU2uPdkDj9am6pm8sE7YtYh1XwL4soYgrk/F+0wqxLeCGfN7H6OvrojwC+A hNFGpfuAcYJNvrbn0Ud5DRA1fw5ml3cSMaNnj8+5/lg8BN+6zqhN+3QnT5XutKlHUU3zeVPeG+dGp Qk6nfhjV02O+dNz3QroVBA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOgGg-0008FO-QP; Wed, 26 Jul 2023 11:17:39 -0400 In-Reply-To: (message from Spencer Baugh on Mon, 24 Jul 2023 15:18:23 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266124 Archived-At: > From: Spencer Baugh > Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com > Date: Mon, 24 Jul 2023 15:18:23 -0400 > > > OK, how about this? > > Oops, that one didn't include the updated > project-uniquify-dirname-transform docstring. The right patch now: Thanks, installed, with some minor changes as followup. The new test uniquify-home fails for me on MS-Windows: Test uniquify-home backtrace: signal(ert-test-failed (((should (equal (mapcar #'buffer-name bufs) ert-fail(((should (equal (mapcar #'buffer-name bufs) '("~" "~< (if (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form (let (form-description-29) (if (unwind-protect (setq value-27 (apply (let ((value-27 'ert-form-evaluation-aborted-28)) (let (form-descrip (let* ((fn-25 #'equal) (args-26 (condition-case err (let ((signal-ho (save-excursion (setq bufs (cons (find-file-noselect "~") bufs)) (se (let (bufs) (save-excursion (setq bufs (cons (find-file-noselect "~" (closure (t) nil (let (bufs) (save-excursion (setq bufs (cons (find- ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name uniquify-home :documentation "uniquif ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [... ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/uniquify-tests.el" " command-line() normal-top-level() Test uniquify-home condition: (ert-test-failed ((should (equal (mapcar ... bufs) '("~" "~<>"))) :form (equal ("~" "nonexistent") ("~" "~<>")) :value nil :explanation (list-elt 0 (arrays-of-different-length 1 7 "~" "~" first-mismatch-at 1)))) The idea of the test is not clear to me, so I cannot tell what could be the reasons. Feel free to ask me to test changes or ask questions about what happens on this Windows system while running the test.