all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>,
	Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 400df210ce0: Fix last change of 'delete-file'
Date: Thu, 10 Aug 2023 18:00:16 +0300	[thread overview]
Message-ID: <83cyzvhri7.fsf@gnu.org> (raw)
In-Reply-To: <87wmy355aa.fsf@gmail.com> (message from Robert Pluim on Thu, 10 Aug 2023 16:41:01 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 10 Aug 2023 16:41:01 +0200
> 
>     >> I was thinking of the opposite case, where someone has a personal file
>     >> handler with a regexp with an absolute path in it.
> 
>     Eli> That'd be a buggy file handler, I think, unless it also checks
>     Eli> default-directory.
> 
> The file handler isnʼt buggy: it never gets a chance to run.
> 
> Let me illustrate. Suppose we have an entry of
> 
> ("\\`/var/.*\\.txt" . my-file-handler)
> 
> in `file-name-handler-alist'.
> 
> (delete-file "foo.txt") when `default-directory' is "/var" would
> previously result in `my-file-handler' being called. Now itʼs not
> called at all, and the deletion is handled by `delete-file-internal'

But the same would be true for substitute-in-file-name, for example,
and for directory-file-name, and file-name-as-directory, and several
other primitives, which call Ffind_file_name_handler without calling
expand-file-name before that.

But maybe I'm missing something here, so let's ask Michael (CC'ed) for
his opinion on this.



  reply	other threads:[~2023-08-10 15:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <169133064669.24990.11219399079845613336@vcs2.savannah.gnu.org>
     [not found] ` <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org>
2023-08-10 13:12   ` master 400df210ce0: Fix last change of 'delete-file' Robert Pluim
2023-08-10 13:25     ` Eli Zaretskii
2023-08-10 13:44       ` Robert Pluim
2023-08-10 13:57         ` Eli Zaretskii
2023-08-10 14:41           ` Robert Pluim
2023-08-10 15:00             ` Eli Zaretskii [this message]
2023-08-11  7:33               ` Michael Albinus
2023-08-11 10:59                 ` Eli Zaretskii
2023-08-11 11:02                 ` Eli Zaretskii
2023-08-11 11:41                   ` Michael Albinus
2023-08-11 12:10                     ` Eli Zaretskii
2023-08-11 17:24                       ` Michael Albinus
2023-08-11 17:47                         ` Eli Zaretskii
2023-08-12  9:57                           ` Michael Albinus
2023-08-12 10:36                             ` Eli Zaretskii
2023-08-12 11:03                               ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cyzvhri7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.