From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter navigation time grows as sqrt(line-number) Date: Sun, 20 Aug 2023 09:18:15 +0300 Message-ID: <83cyzixmmw.fsf@gnu.org> References: <3E82D409-6903-4679-9031-939CA35791FF@gmail.com> <32507689-3b2c-ccbf-dd14-e7bf0bed1ac7@gutov.dev> <6db52945-5459-197c-405d-153ff395a824@gutov.dev> <1F7C956D-6D22-4CC1-8656-6E2A4D07D5FB@gmail.com> <69D18963-D94F-4792-9FF1-159897A99E50@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33892"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jdtsmith@gmail.com, dmitry@gutov.dev, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 20 08:18:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXbm5-0008Z2-Pn for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Aug 2023 08:18:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXblD-0000gV-EC; Sun, 20 Aug 2023 02:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXblB-0000fs-GB for emacs-devel@gnu.org; Sun, 20 Aug 2023 02:18:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXblB-0003J9-6V; Sun, 20 Aug 2023 02:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=btiB6ul4u6VbZtAtVlasmD/Afa6g2T3aFEX62b5aOgM=; b=UZ2V4HlXbnjuRRj7ziuO CXvGGY84g1pUzhKe/LBTZK/i/QJy7zkgQozrpZVcIFC++Mjcikmve2ol3YF3cTdv3FJtTA8nOfhFW L/qDLBZm9NDVtGseRdveLvCGjCTSA9xCOfqCAWXopH/PgZzw6zRpKVMlioOnFpFpyewavNFcJ5Gq0 mBjFVq918oYOqLoiz6c6MDUcdGL+8Z00YkNCPKFwhd2dKgS12U/R9hOn431oxB0FLUZ9QdBCbGmsA g+im0kIaPaJnowOP9mjPhzcYr0GPK7qQeym0QsHKrV+9pcu70xtIgWBeWfZYNhbuk3YuqiqrKETLB LgIX3LfCTYIxdw==; In-Reply-To: <69D18963-D94F-4792-9FF1-159897A99E50@gmail.com> (message from Yuan Fu on Sat, 19 Aug 2023 15:16:12 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308948 Archived-At: > From: Yuan Fu > Date: Sat, 19 Aug 2023 15:16:12 -0700 > Cc: Dmitry Gutov , > emacs-devel@gnu.org > > I inspected the descending algorithm, and there’s indeed an oversight made by me. Here’s a patch that should fix it. I tested it briefly and it does speeds things up greatly. Thanks for investigating this, JD! > > I think the patch is relatively safe, so maybe we can push it to emacs-29 instead of master. Yes, please install on emacs-29 (assuming no one comes up with some regression due to it). Thanks.