From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [IDEA] Add function clean-buffer Date: Wed, 06 Sep 2023 14:59:19 +0300 Message-ID: <83cyyv342w.fsf@gnu.org> References: <87il8qx50p.fsf@breatheoutbreathe.in> <87ledm6i68.fsf@posteo.net> <87a5u0tmwd.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org, mail+gh@daniel-mendler.de To: Joseph Turner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 06 14:00:25 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdrCq-0008cl-6i for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Sep 2023 14:00:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdrCK-0000Fq-5E; Wed, 06 Sep 2023 07:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdrCG-0000FD-PE for emacs-devel@gnu.org; Wed, 06 Sep 2023 07:59:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdrCF-0005Lv-Hb; Wed, 06 Sep 2023 07:59:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f34XQQWd5uiWQQ+zzmV+QuFXiD12yItTK2xpkEOpfa0=; b=NKcTeUXOtvpd V1Wd6K+GowwRP+moLt7/HmgOJ+EbLMcxt4EUvZjw2ulSAb+7G6HInNbG53/rULyGpfyBsca5JsJrl XMa+rtMC/nSUZHy0wkVN2ewdrVQQNJLgqM98gkl0WLG/E0gObkS4lJ1O6xsMfKnfYaarRKFM6tNNu C7WJXaJ+hBHAb1tQVZXr+/dpUyeRraDTIjlfiOEuntEnj7WKYkkWM2KGj93n66Yx+FLaJp3/abL8F 7YB52Xrm8I7KSfZ8V6k0qTGuMV23mPZECX3uL1pIIXeXSjNaPxd2v6sBhUZle3PWK80kNbkD98dFT ZN621f6iymaWt1eZwbDMzA==; In-Reply-To: <87a5u0tmwd.fsf@breatheoutbreathe.in> (message from Joseph Turner on Tue, 05 Sep 2023 12:37:30 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310187 Archived-At: > From: Joseph Turner > Cc: Emacs Devel Mailing List , mail+gh@daniel-mendler.de > Date: Tue, 05 Sep 2023 12:37:30 -0700 > > +(defun clean-buffer (&optional buffer) > + "Remove all local variables, overlays, and text properties in BUFFER. > + When BUFFER is nil, act on current buffer." ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Our usual style is to say BUFFER defaults to the current buffer. or If BUFFER is omitted or nil, it defaults to the current buffer. > + (with-current-buffer (or buffer (current-buffer)) > + (kill-all-local-variables t) > + (let ((inhibit-read-only t)) > + (dolist (overlay (overlays-in (point-min) (point-max))) > + (delete-overlay overlay)) > + (set-text-properties (point-min) (point-max) nil)))) > (define-derived-mode clean-mode fundamental-mode "Clean" > - "A mode that removes all overlays and text properties." > - (kill-all-local-variables t) > - (let ((inhibit-read-only t)) > - (dolist (overlay (overlays-in (point-min) (point-max))) > - (delete-overlay overlay)) > - (set-text-properties (point-min) (point-max) nil) > - (setq-local yank-excluded-properties t))) > + "Mode removing all local variables, overlays, and text properties. Why not the original "Mode that removes"? > +This mode is intended for debugging purposes. For non-interactive ^^ Two spaces between sentences, please. Also, why "For non-interactive use"? The opposite of "debugging purposes" is something like "for other purposes". Thanks.