From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Mon, 11 Sep 2023 16:41:12 +0300 Message-ID: <83cyyorfnr.fsf@gnu.org> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> <878r9losil.fsf@ledu-giraud.fr> <83tts2scvp.fsf@gnu.org> <87cyyo28m0.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32541"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 15:42:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfhBI-0008Hi-L6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 15:42:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfhAt-0000wE-12; Mon, 11 Sep 2023 09:41:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfhAs-0000w3-EW for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 09:41:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfhAs-0000OF-61 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 09:41:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfhAw-00052R-5l for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169443970119323 (code B ref 64440); Mon, 11 Sep 2023 13:42:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 11 Sep 2023 13:41:41 +0000 Original-Received: from localhost ([127.0.0.1]:52382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfhAb-00051b-0v for submit@debbugs.gnu.org; Mon, 11 Sep 2023 09:41:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfhAY-00051N-Q9 for 64440@debbugs.gnu.org; Mon, 11 Sep 2023 09:41:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfhAO-0000GN-OC; Mon, 11 Sep 2023 09:41:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aPgkalshu7XJYAV0ctFltrDY2eapHPCGH+tqM9BfEiA=; b=Oaf8+afxGcNr Xce15y4gx3ZBpPY6aWL6jG1y/lXkvn0CXO3WBCW5Xfh+40cUkWMSeorS+LWGMXOq/HOrJ1RklVtgu erKSgmovh2w2lvweGYx73F7/MMmFY7yMifZRLLYIsHsL0evWHvuIsa5JNNODWodE7gWqvhfw2C3LJ LPDvJdO0uogzB9pqgHr8CF1wLtYVqCXx26IUl8Kz0BxsxD34zYaNfbPGUW5X2PTm8OzeqtMlMd1fZ 22ess626buxxCRYPb2UcmixOCC2IrN66B36fgPatZeofG9KDhwoota/d3gozq+vlTUJ9FoJaAD83v 4OVrPxJEa5fw93YCFRqfjQ==; In-Reply-To: <87cyyo28m0.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 11 Sep 2023 14:32:39 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270043 Archived-At: > From: Manuel Giraud > Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org > Date: Mon, 11 Sep 2023 14:32:39 +0200 > > Eli Zaretskii writes: > > >> + *x_end = *x_start; > >> + for (i = *h_start; i < *h_end; ++i) > >> + *x_end += row->glyphs[TEXT_AREA][i].pixel_width; > >> > >> Here, I convert those limits from chars to pixels. > > > > What does this glyph_row look like? Does it include several strings > > one after the other or something? > > > > In general, we always test the index of a glyph in a glyph row against > > glyphs[TEXT_AREA].used, and I'm worried that these tests are absent > > from the code above. Which is why I'm asking for more details about > > the arrangement of the menu text in these glyph rows. > > Hi, > > Here's what a "p *row" returns right after the "row = MATRIX_ROW > (w->current_matrix, *vpos);" line: > > (gdb) p *row > $9 = { > glyphs = {0xef4a19dd000, 0xef4a19dd000, 0xef4a19e0510, 0xef4a19e0510}, > used = {0, 120, 0, 0}, > hash = 221095522, > x = 0, > y = 0, > pixel_width = 840, > ascent = 11, > height = 13, > phys_ascent = 10, > phys_height = 12, > visible_height = 13, > extra_line_spacing = 0, > start = { > pos = { > charpos = 0, > bytepos = 0 > }, > overlay_string_index = 0, > string_pos = { > charpos = 0, > bytepos = 0 > }, > dpvec_index = 0 > }, > end = { > pos = { > charpos = 0, > bytepos = 0 > }, > overlay_string_index = 0, > string_pos = { > charpos = 0, > bytepos = 0 > }, > dpvec_index = 0 > }, > minpos = { > charpos = 0, > bytepos = 0 > }, > maxpos = { > charpos = 0, > bytepos = 0 > }, > overlay_arrow_bitmap = 0, > left_user_fringe_bitmap = 0, > right_user_fringe_bitmap = 0, > left_fringe_bitmap = 0, > right_fringe_bitmap = 0, > left_user_fringe_face_id = 0, > right_user_fringe_face_id = 0, > left_fringe_face_id = 0, > right_fringe_face_id = 0, > left_fringe_offset = 0, > right_fringe_offset = 0, > fringe_bitmap_periodic_p = false, > redraw_fringe_bitmaps_p = false, > enabled_p = true, > truncated_on_left_p = false, > truncated_on_right_p = false, > continued_p = false, > displays_text_p = false, > ends_at_zv_p = false, > fill_line_p = false, > indicate_empty_line_p = false, > contains_overlapping_glyphs_p = false, > full_width_p = true, > mode_line_p = false, > tab_line_p = false, > overlapped_p = false, > ends_in_middle_of_char_p = false, > starts_in_middle_of_char_p = false, > overlapping_p = false, > mouse_face_p = false, > ends_in_newline_from_string_p = false, > exact_window_width_line_p = false, > cursor_in_fringe_p = false, > ends_in_ellipsis_p = false, > indicate_bob_p = false, > indicate_top_line_p = false, > indicate_eob_p = false, > indicate_bottom_line_p = false, > reversed_p = false, > stipple_p = false, > continuation_lines_width = 0, > clip = 0x0 > } > > Is that what you are looking for? This gives some of the answers, but the command 'pgrow' (defined on src/.gdbinit) would have done that better, and would also show the glyphs themselves. Can you show what 'pgrow' produces in this case?