From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Date: Sat, 16 Dec 2023 09:21:43 +0200 Message-ID: <83cyv6obnc.fsf@gnu.org> References: <78f97339-2aca-0dbd-4cb4-3532af78a895@yandex.ru> <1b16a642-8a85-e693-66fc-41c37df24908@yandex.ru> <36b48587-a723-73ae-fefb-886d69d04ec8@yandex.ru> <83y1dvobun.fsf@gnu.org> <83o7ero61t.fsf@gnu.org> <91c5ddd8-f351-8762-abca-a577acdb942d@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18466"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55871-done@debbugs.gnu.org, n.oje.bar@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 08:23:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEP12-0004aO-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 08:23:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEP0p-0008TS-6t; Sat, 16 Dec 2023 02:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEP0n-0008TE-Ug for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 02:23:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEP0n-0004L6-Mf for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 02:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEP0o-0008RU-2x for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 02:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 07:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55871-done@debbugs.gnu.org id=D55871.170271133132393 (code D ref 55871); Sat, 16 Dec 2023 07:23:02 +0000 Original-Received: (at 55871-done) by debbugs.gnu.org; 16 Dec 2023 07:22:11 +0000 Original-Received: from localhost ([127.0.0.1]:53872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEOzy-0008QO-Vh for submit@debbugs.gnu.org; Sat, 16 Dec 2023 02:22:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEOzx-0008QB-8O for 55871-done@debbugs.gnu.org; Sat, 16 Dec 2023 02:22:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEOzr-0004H0-0G; Sat, 16 Dec 2023 02:22:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pyT8bjRPM8rYAkxow3Esq8xtCRilUnsmYUcT9WOVWeY=; b=C+EyUVgjDjaV YR2Tujs3oOr3RqG/O/8TSk8dv6YXZh6+pqbS6Yym+NfvTGWSweAZY4Yc5+ZpGClrMF9J4tTKRpMZj zYOo//r1WCN7vrzIrahN2AnmEc+8/wXoGPokD7FTb3yswhA+X1wFt0kprWLh2u+2iJtNJWr9UZtok +d8yS5v00e7lncQeyl60aX9b5ZS4zbMKAvgh9QIS2xDcuq9Eu2L6R9i35X7m/KN6oygb1Z7KFzKSw TA1AzD/fYhTSgGEfZK7zpqOSmKemHb34/YCdfu9p/Lqm5o+RQrHtycF6mLCSAnzIB3UpQ8GAgcuFV gpSny8CX17pmPz5URWqz2g==; In-Reply-To: <91c5ddd8-f351-8762-abca-a577acdb942d@yandex.ru> (message from Dmitry Gutov on Fri, 15 Dec 2023 22:45:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276298 Archived-At: > Date: Fri, 15 Dec 2023 22:45:24 +0200 > Cc: 55871-done@debbugs.gnu.org, n.oje.bar@gmail.com > From: Dmitry Gutov > > >> We could say that the problem is relevant to Git and Hg, and the current > >> solution only helps Git. I'm not sure what's the best phrasing, however, > >> which won't bloat the NEWS entry too much. > > > > That'd be fine, and the wording could just use what you say above. > > Ah well, while investigating what Hg does and does not, I ended up > implementing the change for it as well. Thanks. > >>> 'a' doesn't work > >>> (evidently, "bzr annotate -r REVISION FILE" doesn't work when FILE did > >>> not exist in REVISION, but was renamed by a later revision, and one > >>> needs to run "bzr status -Sr REVISION" and look for the "renamed" > >>> report in the result, which will then provide the previous name). > >> > >> But when we're asking for 'annotate' for a file in some old revision > >> (under old name), it won't be the same revision where it had been > >> renamed, 99% of the time. > > > > It doesn't matter. The above-mentioned bzr command will show the > > telltale "RM old => new" status. Keep in mind that "-r REVISION" in > > bzr means "since REVISION till the current head". > > Ah, you mean some code will need to search through the changes up until > revision to find all renames anyway? Yes, similar to what vc-git/hg-file-name-changes do. > I suppose that could be implemented in vc-bzr-annotate (independent > of this changeset). Yes, most probably.