From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67794: 30.0.50; mouse-face is not respected on SVG images Date: Tue, 19 Dec 2023 15:03:28 +0200 Message-ID: <83cyv2ibtr.fsf@gnu.org> References: <838r5yroyp.fsf@gnu.org> <87v8920xlb.fsf@ledu-giraud.fr> <835y12rle4.fsf@gnu.org> <87bkatgnj6.fsf@ledu-giraud.fr> <83plz9qgsb.fsf@gnu.org> <877clh868o.fsf@ledu-giraud.fr> <83jzphqeto.fsf@gnu.org> <87frzzai4h.fsf@ledu-giraud.fr> <87il4v8iim.fsf@ledu-giraud.fr> <87msu6tl80.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 67794@debbugs.gnu.org, alan@idiocy.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 14:05:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFZmc-00062U-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 14:05:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFZmO-0003Z9-P3; Tue, 19 Dec 2023 08:05:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFZmN-0003Yo-T6 for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:04:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFZmN-0000xw-KP for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:04:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFZmQ-0000M3-5S for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67794 X-GNU-PR-Package: emacs Original-Received: via spool by 67794-submit@debbugs.gnu.org id=B67794.17029910471283 (code B ref 67794); Tue, 19 Dec 2023 13:05:02 +0000 Original-Received: (at 67794) by debbugs.gnu.org; 19 Dec 2023 13:04:07 +0000 Original-Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFZlX-0000Kc-0t for submit@debbugs.gnu.org; Tue, 19 Dec 2023 08:04:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFZlU-0000K3-FN for 67794@debbugs.gnu.org; Tue, 19 Dec 2023 08:04:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFZlL-0000rN-Lk; Tue, 19 Dec 2023 08:03:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hn6DXk7hXcqYAJAeFo9LYaN5A976GS3rjGuakdMUzKE=; b=KIKyxGzajQCn r2OvrEDve/5Oe6pYJF1NCrKQSLIyoBSyeplxygSD3APZxPCggR5k7wQCx7jjhFfGOU0T009P2Xphb eFYOISmi8t2tGtXCzRK9re5A9BJUPTHyzld0IvndU9tQ0Pp9kjwI8OtfNsTpJUh/Fmxv8YeK7utsp Ut+KIXiG4TueduevSZNJe0Q3peUMpw0BA8qWiHxgG8ZZRDziCGZUA2MfXDOr1KL+UltCB4+Nmpkw5 NOlfKw4VTLIZOgO+QGCDKCO1EpodTc5c+C1dTqk+fI+aDZPpXMjAnH3Z/GzdcuSoGAm6uKK5IC4qp pDtes98G+OYt67tvPh5ghw==; In-Reply-To: <87msu6tl80.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 19 Dec 2023 13:45:03 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276512 Archived-At: > From: Manuel Giraud > Cc: Eli Zaretskii , gerd.moellmann@gmail.com, > 67794@debbugs.gnu.org > Date: Tue, 19 Dec 2023 13:45:03 +0100 > > > I believe that we need to do some final set-up for the image under > > X/GTK/whatever and it looks as though this is all that's needed: > > > > id = lookup_image (f, s->img->spec, hlinfo->mouse_face_face_id); > > s->img = IMAGE_FROM_ID (f, id); > > prepare_image_for_display (f, s->img); <------ > > > > Under X we need to send the image to the X server, and under Cairo it > > does some other stuff. That's what prepare_image_for_display does. It > > does nothing under NS, so the image worked fine under GNUstep. > > Thank you Alan! That does the trick. So here is an updated version of > the patch that works with XRender (i'll test with cairo). With this change, if you move the mouse pointer on and off the image several times, what happens to the Emacs memory footprint? Specifically, how many times is memory allocated for the SVG image, and if it's allocated each time, does it ever get deallocated?