From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sun, 14 Jan 2024 09:07:51 +0200 Message-ID: <83cyu4fl4o.fsf@gnu.org> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> <83v886sgtl.fsf@gnu.org> <4719da9bc2bbcffdb634@heytings.org> <87bk9o1ooo.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, stefankangas@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 14 08:08:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOubi-0000QQ-NU for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Jan 2024 08:08:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOubM-0006qL-MN; Sun, 14 Jan 2024 02:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOubK-0006q4-Vn for emacs-devel@gnu.org; Sun, 14 Jan 2024 02:08:11 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOubK-0007UM-J2; Sun, 14 Jan 2024 02:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+q6+3ApLOCy0fNApFi0uOBgc1iTH9BcilhBPO3x+CyI=; b=Jq8RzYTVOcCj J5GFH5+wGn83b9gh9uDsPAfEbaqg3Yif4rWmr4Ko9YZMjs6HVWfHZsdWgK0Ntfwi/1RfFGxqC4Coc tYJ4Z5NawGL1ThQPYE8z24CXhBgEmlMJTkoaJYg5spDE5YbQxi53YkhdrubeF9wKnDX3aU5a1ZIXb CAtMZ4zeC5nKEFfNuXJVFsNIMEzWDTMz4EEbdVmFjMiyYzsf2yzWPf4JyDKC8wHIQe0Ue42cg5rht Mo1OnoYRHo1GrXM1Why9XgF7KaV5VVmFohqcxRTQNknVK9ZO7ClCWhxtr8Cx507Bgga7NzektfruS H1onGI0mGw3rRdYFaRZvDw==; In-Reply-To: <87bk9o1ooo.fsf@yahoo.com> (message from Po Lu on Sun, 14 Jan 2024 13:14:47 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314953 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org > Date: Sun, 14 Jan 2024 13:14:47 +0800 > > Gregory Heytings writes: > > > FYI, Stefan's change did not break any build. "typeof" is supported > > by all compilers with which Emacs can be built, either with the > > keyword "typeof" or with the keyword "__typeof__". The only notable > > compiler that does not support "typeof" is MSVC, with which Emacs > > cannot be built. > > Stefan's change (which I reverted) did not use __typeof__. Instead of reverting, the swap macro could have used __typeof__ where typeof is not available. This has been pointed out several times already, so I don't understand why you keep raising this non-issue. > > "Every implementation in existence since C89 has an implementation of > > typeof. Some compilers (GCC, Clang, EDG, tcc, and many, many more) > > expose this with the implementation extension typeof. [...] This > > feature is the most "existing practice"-iest feature to be proposed to > > the C Standard, possibly in the entire history of the C standard. The > > feature was also mentioned in an "extension round up" paper that went > > over the state of C Extensions in 2007. typeof was also considered an > > important extension during the discussion of that paper, but nobody > > brought forth the paper previously to make it a reality." > > Considering that EDG and GNU/Linux compilers are the only compilers you > have named as examples, this list is nowhere near sufficient to prove > that "typeof" does not break any build. Which is a very presumptuous > statement whatever the length of your list, when a build breaking was in > fact the reason for this change... The only breakage we know of was with a compiler that does support __typeof__, AFAIU, so again: why do you keep insisting on your absolute rejection of the macro, when all the real problems have been addressed?