From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: gregory@heytings.org, stefankangas@gmail.com, emacs-devel@gnu.org
Subject: Re: master 37889523278: Add new `swap` macro and use it
Date: Sun, 14 Jan 2024 09:07:51 +0200 [thread overview]
Message-ID: <83cyu4fl4o.fsf@gnu.org> (raw)
In-Reply-To: <87bk9o1ooo.fsf@yahoo.com> (message from Po Lu on Sun, 14 Jan 2024 13:14:47 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, stefankangas@gmail.com, emacs-devel@gnu.org
> Date: Sun, 14 Jan 2024 13:14:47 +0800
>
> Gregory Heytings <gregory@heytings.org> writes:
>
> > FYI, Stefan's change did not break any build. "typeof" is supported
> > by all compilers with which Emacs can be built, either with the
> > keyword "typeof" or with the keyword "__typeof__". The only notable
> > compiler that does not support "typeof" is MSVC, with which Emacs
> > cannot be built.
>
> Stefan's change (which I reverted) did not use __typeof__.
Instead of reverting, the swap macro could have used __typeof__ where
typeof is not available. This has been pointed out several times
already, so I don't understand why you keep raising this non-issue.
> > "Every implementation in existence since C89 has an implementation of
> > typeof. Some compilers (GCC, Clang, EDG, tcc, and many, many more)
> > expose this with the implementation extension typeof. [...] This
> > feature is the most "existing practice"-iest feature to be proposed to
> > the C Standard, possibly in the entire history of the C standard. The
> > feature was also mentioned in an "extension round up" paper that went
> > over the state of C Extensions in 2007. typeof was also considered an
> > important extension during the discussion of that paper, but nobody
> > brought forth the paper previously to make it a reality."
>
> Considering that EDG and GNU/Linux compilers are the only compilers you
> have named as examples, this list is nowhere near sufficient to prove
> that "typeof" does not break any build. Which is a very presumptuous
> statement whatever the length of your list, when a build breaking was in
> fact the reason for this change...
The only breakage we know of was with a compiler that does support
__typeof__, AFAIU, so again: why do you keep insisting on your
absolute rejection of the macro, when all the real problems have been
addressed?
next prev parent reply other threads:[~2024-01-14 7:07 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org>
[not found] ` <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org>
2024-01-06 7:39 ` master 37889523278: Add new `swap` macro and use it Po Lu
2024-01-06 8:44 ` Eli Zaretskii
2024-01-06 8:45 ` Po Lu
2024-01-06 9:18 ` Stefan Kangas
2024-01-06 10:33 ` Po Lu
2024-01-06 11:30 ` Stefan Kangas
2024-01-06 13:13 ` Po Lu
2024-01-06 13:59 ` Eli Zaretskii
2024-01-06 14:41 ` Po Lu
2024-01-06 15:34 ` Eli Zaretskii
2024-01-07 1:39 ` Po Lu
2024-01-07 6:34 ` Stefan Kangas
2024-01-07 7:50 ` Po Lu
2024-01-07 8:33 ` Eli Zaretskii
2024-01-07 9:45 ` Stefan Kangas
2024-01-07 10:36 ` Po Lu
2024-01-07 11:34 ` Eli Zaretskii
2024-01-07 11:53 ` Po Lu
2024-01-07 14:37 ` Eli Zaretskii
2024-01-07 17:32 ` Stefan Kangas
2024-01-08 2:15 ` Po Lu
2024-01-07 7:09 ` Eli Zaretskii
2024-01-12 0:50 ` Gregory Heytings
2024-01-13 10:16 ` Stefan Kangas
2024-01-14 3:03 ` Richard Stallman
2024-01-14 5:14 ` Po Lu
2024-01-14 7:07 ` Eli Zaretskii [this message]
2024-01-14 8:05 ` Po Lu
2024-01-14 9:31 ` Eli Zaretskii
2024-01-15 1:32 ` Gregory Heytings
2024-01-15 12:41 ` Eli Zaretskii
2024-01-15 13:56 ` Po Lu
2024-01-15 14:13 ` Eli Zaretskii
2024-01-18 1:01 ` Gregory Heytings
2024-01-18 2:11 ` Po Lu
2024-01-27 1:26 ` Gregory Heytings
2024-01-27 2:58 ` Po Lu
2024-01-27 23:44 ` Stefan Kangas
2024-01-28 1:51 ` Po Lu
2024-01-28 2:35 ` Stefan Kangas
2024-01-28 4:17 ` Po Lu
2024-01-28 6:28 ` Eli Zaretskii
2024-01-28 2:22 ` Gregory Heytings
2024-01-28 4:03 ` Po Lu
2024-01-30 2:00 ` Gregory Heytings
2024-01-30 2:41 ` Po Lu
2024-01-28 6:40 ` Eli Zaretskii
2024-01-30 1:59 ` Gregory Heytings
2024-01-30 12:41 ` Eli Zaretskii
2024-01-18 6:22 ` Eli Zaretskii
2024-01-27 1:25 ` Gregory Heytings
2024-01-27 3:08 ` Po Lu
2024-01-27 7:19 ` Eli Zaretskii
2024-01-17 3:29 ` Richard Stallman
2024-01-17 10:16 ` Stefan Kangas
2024-01-17 11:15 ` Po Lu
2024-01-17 21:15 ` Stefan Kangas
2024-01-18 0:39 ` Po Lu
2024-01-18 19:17 ` Stefan Kangas
2024-01-19 1:10 ` Po Lu
2024-01-20 20:31 ` Stefan Kangas
2024-01-22 3:35 ` Richard Stallman
2024-01-22 4:48 ` Po Lu
2024-01-22 18:21 ` Dmitry Gutov
2024-01-23 0:50 ` Po Lu
2024-01-25 23:38 ` Stefan Kangas
2024-01-26 2:02 ` Po Lu
2024-01-26 7:53 ` Eli Zaretskii
2024-01-26 7:38 ` Eli Zaretskii
2024-01-19 3:32 ` Richard Stallman
2024-01-19 4:12 ` Po Lu
2024-01-27 1:27 ` Gregory Heytings
2024-01-27 23:56 ` Stefan Kangas
2024-01-28 2:23 ` Gregory Heytings
2024-01-13 8:02 ` Stefan Kangas
2024-01-13 9:14 ` Eli Zaretskii
2024-01-13 9:50 ` Mattias Engdegård
2024-01-06 8:50 ` Stefan Kangas
2024-01-06 9:09 ` Po Lu
2024-01-06 9:52 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cyu4fl4o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=luangruo@yahoo.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.