From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-21.1.94 crash in gnus on Windows Date: Thu, 25 Mar 2010 21:51:03 +0200 Message-ID: <83bpecgoyg.fsf@gnu.org> References: <84634x887o.fsf@gmail.com> <4B9F7F5F.1040504@gmail.com> <84eijkm21x.fsf@gmail.com> <87tys5be09.fsf@stupidchicken.com> <83fx3pghrq.fsf@gnu.org> <87y6hg5phi.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1269550726 4645 80.91.229.12 (25 Mar 2010 20:58:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2010 20:58:46 +0000 (UTC) Cc: andrewjmoreton@gmail.com, schwab@linux-m68k.org, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 25 21:58:41 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nuu8U-0001pT-0j for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 21:58:38 +0100 Original-Received: from localhost ([127.0.0.1]:53805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nuu8T-0007dx-Hn for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 16:58:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nut6R-0003Q8-Bx for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:52:27 -0400 Original-Received: from [140.186.70.92] (port=50524 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nut6F-0003B3-Ca for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:52:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nut5W-0001VW-Og for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:51:31 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:35712) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nut5W-0001VO-C1 for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:51:30 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KZU00000SEDZH00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 25 Mar 2010 21:51:03 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.176.135]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KZU00JS0SH2CXD0@a-mtaout22.012.net.il>; Thu, 25 Mar 2010 21:51:03 +0200 (IST) In-reply-to: <87y6hg5phi.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122674 Archived-At: > From: Chong Yidong > Cc: schwab@linux-m68k.org, andrewjmoreton@gmail.com, emacs-devel@gnu.org > Date: Thu, 25 Mar 2010 12:35:05 -0400 > > Eli Zaretskii writes: > > > But the part that you left in the code also uses it.glyph_row, which > > is garbage after a call to move_it_to. There's a single use of > > it.glyph_row->x before the call to PRODUCE_GLYPHS (&it2), and I think > > that needs to be fixed as well, because it potentially dereferences a > > bad pointer. > > > > Or did I miss something? > > I don't see the failure condition. This branch handles the special case > of charpos == 1 or charpos above the top of the window. Since > start_display initialized the iterator using the desired matrix of the > window, it.glyph_row should always be valid. > > Or am I confused? it.glyph_row is indeed initialized in start_display. But are you sure it.glyph_row->x is set correctly? move_it_to does not produce glyphs in glyph_row, so who computes glyph_row->x ?