all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@m17n.org>
Cc: jasonr@gnu.org, emacs-devel@gnu.org
Subject: Re: [emacs-bidi] Treatment of LRE,RLE,LRO,RLO,PDF,LRM,RLM
Date: Sat, 13 Nov 2010 15:44:55 +0200	[thread overview]
Message-ID: <83bp5te3s8.fsf@gnu.org> (raw)
In-Reply-To: <tl7vd4hv4ry.fsf@m17n.org>

> From: Kenichi Handa <handa@m17n.org>
> Date: Mon, 01 Nov 2010 17:15:13 +0900
> Cc: emacs-bidi@gnu.org, emacs-devel@gnu.org
> 
> Actually, glyphless-char-control should be a customizable
> variable with proper set: function.  But, I don't know how
> to write the correct 'defcustom' form.  Could someone DTRT?

I didn't do this; volunteers are welcome.

> (2) For Windows port:
> 
> I wrote x_draw_glyphless_glyph_string_foreground (in
> w32term.c) by referring to x_draw_glyph_string_foreground in
> the same file.  But, it doesn't draw acronym nor hexa-code.
> I couldn't figure out what is wrong.  Please someone who
> knows Windows code fix it.

I fixed this.  The problem was that w32_draw_rectangle wiped out what
was drawn inside it; I switched the order, so the box is drawn before
the glyphs inside it.  Jason, could you please take a look and see if
I did everything right?

Assuming that on X the order doesn't matter (does it?), perhaps we
should switch the order there as well, for uniformity.

> (3) For mac port:
> 
> As I have no idea how to write a code for mac, the 'case
> GLYPHLESS_GLYPH:' part in ns_draw_glyph_string (in nsterm.m)
> is not finished.  Please fill in the correct code by
> referring to x_draw_glyph_string_foreground in xterm.c.

Not done; I have no idea how to do this.

In addition, I did this:

 . renamed glyphless-char-control to glyphless-char-display-control

 . renamed hexa-code to hex-code.

 . changed TTY display top enclose U+nnnn and "empty box" displays in
   "[]", to simulate a box and make the display easier to read.

 . documented this feature in NEWS and in the manual.

There are a few issues with TTY display, see my other mail.



  parent reply	other threads:[~2010-11-13 13:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tl7hbis1xop.fsf@m17n.org>
     [not found] ` <AANLkTinrGPzGquxPmfigvZLzGbids39yU942sfwKGMYk@mail.gmail.com>
2010-08-19  2:49   ` [emacs-bidi] Treatment of LRE,RLE,LRO,RLO,PDF,LRM,RLM Kenichi Handa
2010-11-01  8:15     ` Kenichi Handa
2010-11-01  9:57       ` Eli Zaretskii
2010-11-01 11:16         ` Kenichi Handa
2010-11-13 13:51           ` [emacs-bidi] " Eli Zaretskii
2010-11-17  5:58             ` Kenichi Handa
2010-11-17  7:14               ` Kenichi Handa
2010-11-17 12:21               ` Eli Zaretskii
2010-11-17 19:20                 ` Eli Zaretskii
2010-11-13 13:44       ` Eli Zaretskii [this message]
2010-11-13 14:07         ` Eli Zaretskii
2010-11-17  3:57         ` Kenichi Handa
2010-11-17 12:26           ` Eli Zaretskii
2010-11-17 12:55             ` Andreas Schwab
2010-11-17 13:24               ` Stefan Monnier
2010-11-18 20:07                 ` Eli Zaretskii
2010-11-17 17:54               ` Eli Zaretskii
2010-11-17 23:59                 ` Stefan Monnier
2010-11-18 20:04                   ` Eli Zaretskii
2010-11-18 22:15                     ` Stefan Monnier
2010-11-19 11:31                       ` Eli Zaretskii
2010-11-20 15:06                       ` Eli Zaretskii
2010-11-19  9:53                     ` Andreas Schwab
2010-11-19 11:31                       ` Eli Zaretskii
2010-11-19 11:47                         ` Andreas Schwab
2010-11-17 19:39             ` Eli Zaretskii
2010-11-26 12:20               ` Eli Zaretskii
2010-11-26 12:29               ` Kenichi Handa
2010-11-27  8:42                 ` Eli Zaretskii
2010-11-29  6:35                   ` Kenichi Handa
2010-11-29 18:06                     ` Stefan Monnier
2010-11-20 14:38           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bp5te3s8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=jasonr@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.