From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: How many more gnulib imports? Date: Mon, 21 Feb 2011 21:05:55 +0200 Message-ID: <83bp25tdgs.fsf@gnu.org> References: <4D60F860.6020303@cs.ucla.edu> <4D613998.6000607@gmail.com> <4D613DB1.9030705@gmail.com> <83mxlqty36.fsf@gnu.org> <4D61A478.3000603@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1298315175 26945 80.91.229.12 (21 Feb 2011 19:06:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 Feb 2011 19:06:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 21 20:06:11 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Prb5F-0006Sw-Q6 for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 20:06:09 +0100 Original-Received: from localhost ([127.0.0.1]:56646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prb5F-0003DN-1g for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 14:06:09 -0500 Original-Received: from [140.186.70.92] (port=40843 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Prb59-0003D4-Oc for emacs-devel@gnu.org; Mon, 21 Feb 2011 14:06:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Prb58-0001e5-H8 for emacs-devel@gnu.org; Mon, 21 Feb 2011 14:06:03 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:45772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Prb58-0001dr-AW for emacs-devel@gnu.org; Mon, 21 Feb 2011 14:06:02 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LGZ00400E7PJB00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Mon, 21 Feb 2011 21:05:56 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.14.198]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LGZ004ZOEDUBUM0@a-mtaout21.012.net.il>; Mon, 21 Feb 2011 21:05:56 +0200 (IST) In-reply-to: <4D61A478.3000603@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136332 Archived-At: > Date: Sun, 20 Feb 2011 16:32:08 -0700 > From: Christoph > CC: emacs-devel@gnu.org > > > However, this change will only work with MinGW, since it has stdint.h. > > To make it work with MSVC, we need to add nt/inc/stdint.h, and make > > lib/md5.$(O) depend on it. For MinGW, nt/inc/stdint.h could just say > > "#include_next" (conditioned on __GNUC__ being non-zero). > > Otherwise, it should include the minimum needed for md5.c to compile. > > Paul said a few messages ago that all that's needed for now is this: > > > > typedef unsigned int uint32_t; > > > > Could you please commit such a followup change, after you test it (see > > below)? If not, I will get to it in due time. > > See attached patch. Thanks. I will commit it as soon as the Windows build is fixed (it became broken due to the import of filemode.c from gnulib). Please note that nt/inc/stdint.h you sent has DOS EOLs. We generally use Unix EOLs, except in DOS/Windows batch files.