all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: merge-commits policy
Date: Tue, 17 May 2011 20:57:59 +0300	[thread overview]
Message-ID: <83boz1gqfs.fsf@gnu.org> (raw)
In-Reply-To: <jwvliy5v48e.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: eggert@cs.ucla.edu,  emacs-devel@gnu.org
> Date: Tue, 17 May 2011 10:42:32 -0300
> 
> >   revno: 103104 [merge]
> >   committer: Paul Eggert <eggert@cs.ucla.edu>
> >   branch nick: trunk
> >   timestamp: Thu 2011-02-03 11:30:24 -0800
> >   message:
> >     merge: allow C code to suppress warnings about ignored return values
> >   ------------------------------------------------------------
> 
> The same holds for "merge from emacs-23" or any other merge for that matter.

Except that emacs-23 is a public branch which can be examined
directly, unlike private branches that cannot.

> > Yes, invoking "bzr log" with the -n0 or --include-merges switch would
> > have shown that the second one of these two mentions texinfo.tex in
> > its branch commit.
> 
> Exactly.

Exactly: harder.

> As would searching the ChangeLog rather than "bzr log".

Unfortunately, only some of these updates are reflected in
doc/misc/ChangeLog, and some aren't, so this is unreliable.

> Personally I would use C-x v l and/or C-x v g from the texinfo.tex buffer.

"C-x v l" takes ages for veteran files (because texinfo.tex was
"cvs mv"ed, it appears to have been born relatively recently, so it is
spared this problem).  To be efficient, you need to run "bzr log" for
a certain range of revisions.

"C-x v g" is fine only the first time.  Once you find the latest
revision that modified some line, and need to see the previous
revisions that modified the same line, you need to find the exact
revision number and use "-r before:", or else you will miss some of
the change history, e.g. if there were more than one change on the
branch before it was merged.

Like I said: possible, but harder.

> > different features and unrelated bugfixes.  If you regard any "sync
> > from gnulib" as a single self-contained changeset, then at least it
> > should be committed to mainline separately from other changes.
> 
> That would make sense, yes.  Although in the case of gnulib, most
> "syncs" happen because we import yet another module, so it's OK to do
> both "import foo module" and "sync" at the same time, but indeed, the
> commit message should indicate that a sync with gnulib took place.

Thanks, I hope this is acceptable.



  reply	other threads:[~2011-05-17 17:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16  5:07 bug#8675: lisp_string_width and strings wider than INT_MAX Paul Eggert
2011-05-16  5:30 ` Eli Zaretskii
2011-05-16  5:33   ` Paul Eggert
2011-05-16  7:57     ` Eli Zaretskii
2011-05-16 16:37       ` Paul Eggert
2011-05-16 16:48       ` Stefan Monnier
2011-05-17  9:52         ` Eli Zaretskii
2011-05-17 10:30         ` merge-commits policy (was: bug#8675: lisp_string_width and strings wider than INT_MAX) Eli Zaretskii
2011-05-17 13:42           ` merge-commits policy Stefan Monnier
2011-05-17 17:57             ` Eli Zaretskii [this message]
2011-05-17 19:50               ` Stefan Monnier
2011-05-18  1:33 ` bug#8675: committed fix into trunk Paul Eggert
2011-05-18  2:26   ` Christoph Scholtes
2011-05-18  2:48     ` Paul Eggert
2011-05-18  3:19       ` Christoph Scholtes
2011-05-18 12:39       ` Andreas Schwab
2011-05-18 19:55         ` bug#8675: error: token "@" is not valid in preprocessor expressions Paul Eggert
     [not found]         ` <4DD42421.6090906@cs.ucla.edu>
2011-05-18 20:35           ` Andreas Schwab
     [not found]           ` <m262p7u4ph.fsf@igel.home>
2011-05-18 22:59             ` Paul Eggert
     [not found]             ` <4DD44F42.1050405@cs.ucla.edu>
2011-05-19  0:27               ` Bruno Haible
     [not found]               ` <201105190227.26215.bruno@clisp.org>
2011-05-19  1:47                 ` Christoph Scholtes
2011-05-19  7:39                   ` Paul Eggert
2011-05-18  6:54   ` bug#8664: committed fix into trunk Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2011-05-12 19:58 bug#8664: * keyboard.c (make_lispy_event): Fix problem in integer overflow Paul Eggert
2011-05-12 20:26 ` bug#8664: Being more-systematic about user-interface timestamps Paul Eggert
2011-05-13  8:53   ` Eli Zaretskii
2011-05-14  9:10     ` Paul Eggert
2011-05-14  9:41       ` Eli Zaretskii
2011-05-14 19:09         ` Paul Eggert
2011-05-14 20:47           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83boz1gqfs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.