From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9006: 24.0.50; Abort in unshow_buffer/kill-buffer Date: Sat, 09 Jul 2011 20:31:42 +0300 Message-ID: <83box3nywx.fsf@gnu.org> References: <877h7wxqjv.fsf@escher.fritz.box> <4E1429F3.1010305@gmx.at> <87oc17xlmu.fsf@escher.fritz.box> <4E156D17.8020804@gmx.at> <871uy2qvv6.fsf@escher.fritz.box> <4E15D520.4030809@gmx.at> <87mxgobcj6.fsf@escher.fritz.box> <4E1814F7.4060002@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1310232869 25524 80.91.229.12 (9 Jul 2011 17:34:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 9 Jul 2011 17:34:29 +0000 (UTC) Cc: 9006@debbugs.gnu.org, stephen.berman@gmx.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 09 19:34:22 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QfbQ5-0005k6-3a for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2011 19:34:21 +0200 Original-Received: from localhost ([::1]:41337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfbQ4-0006qI-11 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2011 13:34:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:59608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfbPo-0006px-9Q for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 13:34:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfbPm-00047O-SV for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 13:34:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfbPm-00047E-Mj for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 13:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QfbPm-0005mu-7z; Sat, 09 Jul 2011 13:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2011 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9006-submit@debbugs.gnu.org id=B9006.131023282922230 (code B ref 9006); Sat, 09 Jul 2011 17:34:02 +0000 Original-Received: (at 9006) by debbugs.gnu.org; 9 Jul 2011 17:33:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfbPZ-0005mV-5Y for submit@debbugs.gnu.org; Sat, 09 Jul 2011 13:33:49 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfbPX-0005mH-6E for 9006@debbugs.gnu.org; Sat, 09 Jul 2011 13:33:48 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LO200J00U3AGK00@a-mtaout23.012.net.il> for 9006@debbugs.gnu.org; Sat, 09 Jul 2011 20:33:40 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.156.102]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LO200J5LU42AT50@a-mtaout23.012.net.il>; Sat, 09 Jul 2011 20:33:40 +0300 (IDT) In-reply-to: <4E1814F7.4060002@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 09 Jul 2011 13:34:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48340 Archived-At: > Date: Sat, 09 Jul 2011 10:44:39 +0200 > From: martin rudalics > Cc: 9006@debbugs.gnu.org > > I think there are three problems with this. > > > #1 0x080a71a7 in unshow_buffer (w=0x9a8e828) > > at /data/steve/bzr/emacs/quickfixes/src/window.c:1801 > > buf = 218835381 > > b = 0xd0b29b0 > > This problem is certainly due to the fact that vertical_motion blindly > does > > if (XBUFFER (w->buffer) != current_buffer) > { > /* Set the window's buffer temporarily to the current buffer. */ > old_buffer = w->buffer; > XSETBUFFER (w->buffer, current_buffer); > } > > and probably should do at least something like > > if (XBUFFER (w->buffer) != current_buffer) > { > /* Set the window's buffer temporarily to the current buffer. */ > old_buffer = w->buffer; > XSETBUFFER (w->buffer, current_buffer); > set_marker_both (w->pointm, buffer, BEG, BEG_BYTE); > } > > instead. How is vertical-motion relevant to the user typing C-g? And why does this code normally works, if it is wrong? What am I missing? > Allowing to kill a temporary buffer while it's shown in a window just to > calculate how far `vertical-motion' would go if the buffer were shown in > a window is asking for trouble. I don't understand how come vertical-motion ended up calling Lisp, as this Lisp backtrace shows: > Lisp Backtrace: > "set-window-buffer" (0xbfff66d4) > "set-window-buffer-start-and-point" (0xbfff6854) > "byte-code" (0xbfff6964) > "switch-to-prev-buffer" (0xbfff6c54) > "replace-buffer-in-windows" (0xbfff6dec) > "kill-buffer" (0xbfff6eb4) > "and" (0xbfff6fa8) > "vertical-motion" (0xbfff7d24) And why does that Lisp code call kill-buffer?