From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11519: "Wrong type argument: characterp" building custom-deps while boostrapping Date: Mon, 28 May 2012 23:47:13 +0300 Message-ID: <83bol8119q.fsf@gnu.org> References: <83d360yw48.fsf@gnu.org> <834nrazrtl.fsf@gnu.org> <831umez1p7.fsf@gnu.org> <83vcjpxw18.fsf@gnu.org> <83k404xcpt.fsf@gnu.org> <83hav8xak1.fsf@gnu.org> <83ehqby542.fsf@gnu.org> <838vgiyh4q.fsf@gnu.org> <83wr41wnu1.fsf@gnu.org> <83k3zw1c2v.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1338238070 4120 80.91.229.3 (28 May 2012 20:47:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 May 2012 20:47:50 +0000 (UTC) Cc: schwab@linux-m68k.org, rms@gnu.org, 11519@debbugs.gnu.org, lekktu@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 28 22:47:48 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZ6qx-00081l-VG for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 22:47:48 +0200 Original-Received: from localhost ([::1]:49549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ6qx-0000Cs-Op for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 16:47:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ6qv-0000Cm-GU for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 16:47:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ6qt-0000LW-OD for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 16:47:45 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ6qt-0000LR-KW for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 16:47:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZ6sA-00016D-Ez for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 16:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 May 2012 20:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11519 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11519-submit@debbugs.gnu.org id=B11519.13382381354201 (code B ref 11519); Mon, 28 May 2012 20:49:02 +0000 Original-Received: (at 11519) by debbugs.gnu.org; 28 May 2012 20:48:55 +0000 Original-Received: from localhost ([127.0.0.1]:47079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZ6rk-00015K-4b for submit@debbugs.gnu.org; Mon, 28 May 2012 16:48:55 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:44814) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZ6ri-000156-Jd for 11519@debbugs.gnu.org; Mon, 28 May 2012 16:48:35 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M4R00C00310IO00@a-mtaout20.012.net.il> for 11519@debbugs.gnu.org; Mon, 28 May 2012 23:47:08 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M4R00BBS32KH1C0@a-mtaout20.012.net.il>; Mon, 28 May 2012 23:47:08 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60437 Archived-At: > From: Stefan Monnier > Cc: rms@gnu.org, handa@gnu.org, schwab@linux-m68k.org, lekktu@gmail.com, > 11519@debbugs.gnu.org > Date: Mon, 28 May 2012 15:44:18 -0400 > > > I wouldn't recommend removing the calls to > > r_alloc_inhibit_buffer_relocation around calls to regex, as that is an > > external function we don't control. But if you feel strongly about > > that, I will remove them. > > I don't feel strongly about that. But this code is all ours, it's not > an external function (it used to be half-external, and then I hacked on > it half-extensively, after which the new version was sync'd back from > Emacs to gnulib, after which the gnulib side dropped it, and AFAIK Emacs > is the last remaining development line of this code, except maybe for > XEmacs's version). If you are confident that regex.c doesn't call malloc in any other place, and that chances for it to do so in the future are low enough, then I'm okay with removing the calls to r_alloc_inhibit_buffer_relocation.