From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12450: Remove configure's --without-sync-input option. Date: Sun, 16 Sep 2012 11:05:55 +0300 Message-ID: <83boh6s87w.fsf@gnu.org> References: <50543449.1070306@cs.ucla.edu> <83k3vvtyw0.fsf@gnu.org> <5054551A.1070207@cs.ucla.edu> <837grvtuo5.fsf@gnu.org> <5054DE30.1020806@cs.ucla.edu> <83fw6iscip.fsf@gnu.org> <5055842D.7070407@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347782826 7401 80.91.229.3 (16 Sep 2012 08:07:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Sep 2012 08:07:06 +0000 (UTC) Cc: lekktu@gmail.com, rms@gnu.org, 12450@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 16 10:07:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TD9sd-0004M4-2F for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Sep 2012 10:07:03 +0200 Original-Received: from localhost ([::1]:48094 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TD9sY-00043s-Ry for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Sep 2012 04:06:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TD9sV-00043k-SU for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 04:06:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TD9sU-0002yg-Ny for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 04:06:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TD9sU-0002yc-Kf for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 04:06:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TD9tZ-0005IY-UJ for bug-gnu-emacs@gnu.org; Sun, 16 Sep 2012 04:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Sep 2012 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12450 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12450-submit@debbugs.gnu.org id=B12450.134778284920321 (code B ref 12450); Sun, 16 Sep 2012 08:08:01 +0000 Original-Received: (at 12450) by debbugs.gnu.org; 16 Sep 2012 08:07:29 +0000 Original-Received: from localhost ([127.0.0.1]:36366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD9t3-0005Hi-Ji for submit@debbugs.gnu.org; Sun, 16 Sep 2012 04:07:29 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:46227) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TD9t1-0005Ha-On for 12450@debbugs.gnu.org; Sun, 16 Sep 2012 04:07:28 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MAF00B00NTFKA00@a-mtaout22.012.net.il> for 12450@debbugs.gnu.org; Sun, 16 Sep 2012 11:05:51 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAF00A71NTRWDO0@a-mtaout22.012.net.il>; Sun, 16 Sep 2012 11:05:51 +0300 (IDT) In-reply-to: <5055842D.7070407@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64396 Archived-At: > Date: Sun, 16 Sep 2012 00:47:57 -0700 > From: Paul Eggert > CC: Richard Stallman , 12450@debbugs.gnu.org, > lekktu@gmail.com > > On 09/15/2012 11:33 PM, Eli Zaretskii wrote: > >>>> -#ifdef REL_ALLOC > >>>> > >> - malloc_hysteresis = 32; > >>>> > >> -#else > >>>> > >> - malloc_hysteresis = 0; > >>>> > >> -#endif > >> > > >> > malloc_hysteresis is used only by the non-SYNC_INPUT code. > > No, it is also used indirectly, via __malloc_extra_blocks, in > > gmalloc.c and in ralloc.c. > > No, it is not used indirectly. emacs_blocked_malloc is the only > function that uses malloc_hysteresis to set __malloc_extra_blocks. > And emacs_blocked_malloc is invoked only in the non-SYNC_INPUT code. Which means that gmalloc.c, and any memory allocation based on that, will work differently with that function removed, unless we keep __malloc_extra_blocks at its present value. The amount of extra blocks reserved by gmalloc has nothing to do with emacs_blocked_malloc (or at least no one came up with explanation why it does). In the absence of such an explanation, you are suggesting to remove code whose effect on platforms that use gmalloc is not fully understood. > > But there's something I don't understand about this snippet. Why does > > it set the value to 32 conditioned by REL_ALLOC ... > > A nice property of removing the non-SYNC_INPUT code is that > we don't need to worry about cruft like that, because it's > not being used and we can remove it. If we don't understand that "cruft", how can we claim in good faith it's cruft, and how can we remove or modify it in non-trivial ways and still claim with straight face that we are making Emacs more stable and reliable? Perhaps you don't care about platforms that use gmalloc. Otherwise, I don't understand your line of thinking at all.