From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14362: 24.3; Make it possible to modify compilation-find-file Date: Tue, 07 May 2013 22:28:51 +0300 Message-ID: <83bo8megi4.fsf@gnu.org> References: <1D196226-AB6A-49B4-A156-83EDFE9C6905@garethrees.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1367955006 17666 80.91.229.3 (7 May 2013 19:30:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 May 2013 19:30:06 +0000 (UTC) Cc: 14362@debbugs.gnu.org To: Gareth Rees Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 07 21:30:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZnaM-0000AX-Rb for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 May 2013 21:30:02 +0200 Original-Received: from localhost ([::1]:58478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZnaM-0005ze-Fz for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 May 2013 15:30:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZnaJ-0005zL-Ke for bug-gnu-emacs@gnu.org; Tue, 07 May 2013 15:30:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZnaI-0005G6-Do for bug-gnu-emacs@gnu.org; Tue, 07 May 2013 15:29:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZnaI-0005G2-Ab for bug-gnu-emacs@gnu.org; Tue, 07 May 2013 15:29:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UZnbK-0006gE-5P for bug-gnu-emacs@gnu.org; Tue, 07 May 2013 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 May 2013 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14362-submit@debbugs.gnu.org id=B14362.136795500625526 (code B ref 14362); Tue, 07 May 2013 19:31:02 +0000 Original-Received: (at 14362) by debbugs.gnu.org; 7 May 2013 19:30:06 +0000 Original-Received: from localhost ([127.0.0.1]:33154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZnaP-0006df-Ss for submit@debbugs.gnu.org; Tue, 07 May 2013 15:30:06 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:54775) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZnaN-0006ca-Nd for 14362@debbugs.gnu.org; Tue, 07 May 2013 15:30:05 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MMG005000BWE100@a-mtaout23.012.net.il> for 14362@debbugs.gnu.org; Tue, 07 May 2013 22:28:57 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMG005780S9D230@a-mtaout23.012.net.il>; Tue, 07 May 2013 22:28:57 +0300 (IDT) In-reply-to: <1D196226-AB6A-49B4-A156-83EDFE9C6905@garethrees.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74052 Archived-At: > From: Gareth Rees > Date: Tue, 7 May 2013 20:19:04 +0100 > > If the user runs the p4 grep command via my interface, and then clicks > on one of the hits, I want Emacs to jump to the corresponding line in > that revision of the file. But the filename is given in Perforce > server syntax, and compilation-next-error-function does not know how > to visit that file. There seems to be no way to customize the > behaviour of compilation-find-file. > > > SUGGESTION > > The simplest way to support my use case would be to add a new variable > compilation-find-file-function. If this is non-NIL, then call it > instead of compilation-find-file. Suggested patch against 24.3 below. Isn't that what file handlers are for?