From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 14616@debbugs.gnu.org
Subject: bug#14616: 24.3.50; Excessive cursor movement on non-X Emacs
Date: Mon, 05 Aug 2013 22:45:12 +0300 [thread overview]
Message-ID: <83bo5bx6pj.fsf@gnu.org> (raw)
In-Reply-To: <m3haf4eyfh.fsf@stories.gnus.org>
> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Cc: 14616@debbugs.gnu.org
> Date: Mon, 05 Aug 2013 21:21:22 +0200
>
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
> > #<frame F1 0xc12be0>
> > #<frame emacs 0x2f8fba8>
>
> Hm. So... reading the code, it is really trying to switch between the
> two frames, which then means that it has to redraw everything.
The redrawing isn't supposed to happen.
> But why is it trying to switch frames in the first place?
>
> I'm probably reading this wrong, but it's waiting for process output
> (check), but that means that it wants to switch frames. Which I don't
> understand why it'd want to...
Because prepare_menu_bars, called as part of redisplay, loops over all
the frames.
> 0x0000000000420725 in do_switch_frame (frame=12659685, track=1, for_deletion=0, norecord=12571250) at frame.c:844
> 844 SET_FRAME_VISIBLE (XFRAME (frame), 1);
> #0 0x0000000000420725 in do_switch_frame (frame=12659685, track=1, for_deletion=0, norecord=12571250) at frame.c:844
> #1 0x0000000000420829 in Fselect_frame (frame=12659685, norecord=12571250) at frame.c:883
> #2 0x00000000004454ac in unwind_format_mode_line (vector=17901885) at xdisp.c:11002
> #3 0x00000000005ad565 in unbind_to (count=6, value=12571202) at eval.c:3337
> #4 0x0000000000445936 in x_consider_frame_title (frame=48936325) at xdisp.c:11133
> #5 0x0000000000445a34 in prepare_menu_bars () at xdisp.c:11185
> #6 0x00000000004497f6 in redisplay_internal () at xdisp.c:13051
> #7 0x000000000044ac22 in redisplay_preserve_echo_area (from_where=11) at xdisp.c:13643
> #8 0x00000000005f7d4f in wait_reading_process_output (time_limit=30, nsecs=0, read_kbd=-1, do_display=true, wait_for_cell=12571202,
> wait_proc=0x0, just_wait_proc=0) at process.c:4459
Here:
/* Prepare for redisplay by updating menu-bar item lists when
appropriate. This can call eval. */
void
prepare_menu_bars (void)
{
int all_windows;
struct gcpro gcpro1, gcpro2;
struct frame *f;
Lisp_Object tooltip_frame;
#ifdef HAVE_WINDOW_SYSTEM
tooltip_frame = tip_frame;
#else
tooltip_frame = Qnil;
#endif
/* Update all frame titles based on their buffer names, etc. We do
this before the menu bars so that the buffer-menu will show the
up-to-date frame titles. */
#ifdef HAVE_WINDOW_SYSTEM
if (windows_or_buffers_changed || update_mode_lines)
{
Lisp_Object tail, frame;
FOR_EACH_FRAME (tail, frame) <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
{
f = XFRAME (frame);
if (!EQ (frame, tooltip_frame)
&& (FRAME_VISIBLE_P (f) || FRAME_ICONIFIED_P (f)))
x_consider_frame_title (frame);
}
}
#endif /* HAVE_WINDOW_SYSTEM */
Hmmm... maybe we should have here something special for TTY frames. I
will take a look.
Thanks.
next prev parent reply other threads:[~2013-08-05 19:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 8:00 bug#14616: 24.3.50; Excessive cursor movement on non-X Emacs Lars Magne Ingebrigtsen
2013-06-14 8:05 ` Lars Magne Ingebrigtsen
2013-06-23 17:27 ` Eli Zaretskii
2013-06-25 20:18 ` Lars Magne Ingebrigtsen
2013-06-26 16:32 ` Eli Zaretskii
2013-07-19 15:31 ` Lars Magne Ingebrigtsen
2013-07-19 18:46 ` Eli Zaretskii
2013-07-30 14:47 ` Lars Magne Ingebrigtsen
2013-07-30 16:44 ` Eli Zaretskii
2013-07-31 10:03 ` Lars Magne Ingebrigtsen
2013-07-31 10:11 ` Lars Magne Ingebrigtsen
2013-07-31 17:34 ` Eli Zaretskii
2013-08-01 10:41 ` Lars Magne Ingebrigtsen
2013-08-01 16:46 ` Eli Zaretskii
2013-08-02 13:33 ` Lars Magne Ingebrigtsen
2013-08-02 15:07 ` Eli Zaretskii
2013-08-02 13:46 ` Lars Magne Ingebrigtsen
2013-08-02 14:28 ` Eli Zaretskii
2013-08-03 13:00 ` Lars Magne Ingebrigtsen
2013-08-03 13:32 ` Eli Zaretskii
2013-08-05 18:22 ` Lars Magne Ingebrigtsen
2013-08-05 18:45 ` Eli Zaretskii
2013-08-05 19:10 ` Lars Magne Ingebrigtsen
2013-08-05 19:15 ` Lars Magne Ingebrigtsen
2013-08-05 19:21 ` Lars Magne Ingebrigtsen
2013-08-05 19:45 ` Eli Zaretskii [this message]
2013-08-05 19:53 ` Lars Magne Ingebrigtsen
2013-08-06 15:45 ` Eli Zaretskii
2013-08-05 19:40 ` Eli Zaretskii
2013-08-05 19:46 ` Lars Magne Ingebrigtsen
2013-08-05 19:51 ` Lars Magne Ingebrigtsen
2013-08-05 20:10 ` Eli Zaretskii
2013-08-05 20:20 ` Lars Magne Ingebrigtsen
2013-08-06 15:26 ` Eli Zaretskii
2013-08-06 20:32 ` Lars Magne Ingebrigtsen
2013-08-07 13:51 ` Eli Zaretskii
2013-08-02 14:00 ` Lars Magne Ingebrigtsen
2013-08-03 7:57 ` Eli Zaretskii
2013-08-03 13:00 ` Lars Magne Ingebrigtsen
2013-06-14 8:59 ` Eli Zaretskii
2013-06-18 5:22 ` lee
2013-06-18 15:57 ` Eli Zaretskii
2013-06-19 1:38 ` lee
2013-06-27 11:16 ` lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bo5bx6pj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14616@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.