From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16209@debbugs.gnu.org
Subject: bug#16209: 24.3.50; menubar not updated when exiting from splash screen
Date: Fri, 27 Dec 2013 21:13:33 +0200 [thread overview]
Message-ID: <83bo023y5e.fsf@gnu.org> (raw)
In-Reply-To: <wlvbyiy7sb.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Sat, 21 Dec 2013 16:36:52 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> Steps to reproduce:
>
> 1. $ emacs -q &
> 2. Type "q" to exit from the splash screen.
> I'd expect that the new menu bar title "Lisp-Interaction" appears
> for the *scratch* buffer. But the titles in the menubar don't get
> updated.
Stefan, this is a side effect of your commit 115377. It includes this
change in set_window_buffer:
@@ -3364,7 +3363,7 @@ set_window_buffer (Lisp_Object window, L
}
/* Maybe we could move this into the `if' but it's not obviously safe and
I doubt it's worth the trouble. */
- windows_or_buffers_changed = 28;
+ wset_redisplay (w);
However, update_menu_bar only recomputes the menu bar under these
conditions:
if (windows_or_buffers_changed
/* This used to test w->update_mode_line, but we believe
there is no need to recompute the menu in that case. */
|| update_mode_lines
|| window_buffer_changed (w))
{
I can easily fix this bug if I add a test for w->redisplay, but isn't
it too drastic to recompute the menu bar each time a window needs to
be redisplayed?
Perhaps we need a new flag, for when the buffer shown by the window is
changed?
next prev parent reply other threads:[~2013-12-27 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 7:36 bug#16209: 24.3.50; menubar not updated when exiting from splash screen YAMAMOTO Mitsuharu
2013-12-27 19:13 ` Eli Zaretskii [this message]
2021-05-30 5:23 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bo023y5e.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16209@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.