From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16736: Compiling a Lisp file causes display to flash off and on Date: Mon, 17 Feb 2014 20:56:51 +0200 Message-ID: <83bny58t58.fsf@gnu.org> References: <96vbwj696i.fsf@fencepost.gnu.org> <83lhxecftk.fsf@gnu.org> <2smwhurv74.fsf@fencepost.gnu.org> <83iosgbx6b.fsf@gnu.org> <83y51b9gdt.fsf@gnu.org> <0ssirio8re.fsf@fencepost.gnu.org> <83eh329v8a.fsf@gnu.org> <0nlhxa18t7.fsf@fencepost.gnu.org> <83wqgt924q.fsf@gnu.org> <5302377D.3070007@gmx.at> <83iosd8yzj.fsf@gnu.org> <530243FE.8050108@gmx.at> <83eh318xad.fsf@gnu.org> <53024DD2.2020900@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1392663755 8243 80.91.229.3 (17 Feb 2014 19:02:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Feb 2014 19:02:35 +0000 (UTC) Cc: 16736@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 17 20:02:39 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WFTSZ-0004KM-3k for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Feb 2014 20:02:31 +0100 Original-Received: from localhost ([::1]:43683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFTSY-0000ad-Lw for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Feb 2014 14:02:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFTSD-0000AT-CY for bug-gnu-emacs@gnu.org; Mon, 17 Feb 2014 14:02:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFTS7-0001gF-UE for bug-gnu-emacs@gnu.org; Mon, 17 Feb 2014 14:02:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFTS7-0001fS-RY for bug-gnu-emacs@gnu.org; Mon, 17 Feb 2014 14:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WFTNG-0006Ee-EL for bug-gnu-emacs@gnu.org; Mon, 17 Feb 2014 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Feb 2014 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16736 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16736-submit@debbugs.gnu.org id=B16736.139266341623951 (code B ref 16736); Mon, 17 Feb 2014 18:57:02 +0000 Original-Received: (at 16736) by debbugs.gnu.org; 17 Feb 2014 18:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:56965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WFTN9-0006EE-Rq for submit@debbugs.gnu.org; Mon, 17 Feb 2014 13:56:56 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:33783) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WFTN6-0006Dv-Hm for 16736@debbugs.gnu.org; Mon, 17 Feb 2014 13:56:53 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N1500100LN0U400@a-mtaout20.012.net.il> for 16736@debbugs.gnu.org; Mon, 17 Feb 2014 20:56:46 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N15001H0LYLMK60@a-mtaout20.012.net.il>; Mon, 17 Feb 2014 20:56:46 +0200 (IST) In-reply-to: <53024DD2.2020900@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85775 Archived-At: > Date: Mon, 17 Feb 2014 18:58:42 +0100 > From: martin rudalics > CC: rgm@gnu.org, 16736@debbugs.gnu.org > > > OK, so it sounds like we need to make change_frame_size_1 consistent > > with widget.c code. > > IMO the widget.c code is inherently absurd. EmacsFrameResize processes > a resize request by calculating a text size from ew->core.height. Then > it sets > > FRAME_PIXEL_HEIGHT (f) = ew->core.height + x->menubar_height; > > and update_from_various_frame_slots inversely processes > > ew->core.height = FRAME_PIXEL_HEIGHT (f) - x->menubar_height; > > where update_from_various_frame_slots is called only by > EmacsFrameInitialize. Does anyone understand what this is good for? The latter part is not important, I think, because ew->core is not used anywhere. So the only important part here is setting FRAME_PIXEL_HEIGHT and other fields of the frame struct. widget.c is compiled only for X toolkits, right? So I think making update_various_frame_slots consistent with change_frame_size_1 when USE_X_TOOLKIT will fix the problem.