From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 17497@debbugs.gnu.org, dickey@his.com
Subject: bug#17497: 24.4.50; TTY menu glitches
Date: Wed, 04 Jun 2014 20:10:50 +0300 [thread overview]
Message-ID: <83bnu87g85.fsf@gnu.org> (raw)
In-Reply-To: <41d2eo3bd5.fsf@fencepost.gnu.org>
> From: Glenn Morris <rgm@gnu.org>
> Cc: Thomas Dickey <dickey@his.com>, monnier@iro.umontreal.ca, 17497@debbugs.gnu.org
> Date: Wed, 04 Jun 2014 12:09:26 -0400
>
> Eli Zaretskii wrote:
>
> > On the hunch that the problems discussed here are caused by excess
> > movement of the cursor, I've made changes in revision 117203 on the
> > emacs-24 branch to avoid some of them. Please try that.
>
> Sorry, still glitches. :(
If you put a breakpoint in update_frame and in update_frame_with_menu,
like shown below, how many calls do you see when you press an arrow
key (or C-n/C-p) that produces a glitch? I expect 1 call to
update_frame_with_menu followed by one call to update_frame. Here's a
GDB session on fencepost to show what I see:
(gdb) break update_frame
Breakpoint 1 at 0x41b605: file dispnew.c, line 3006.
(gdb) commands
Type commands for breakpoint(s) 3, one per line.
End with a line saying just "end".
>continue
>end
(gdb) break update_frame_with_menu
Breakpoint 2 at 0x41b81b: file dispnew.c, line 3112.
(gdb) commands
Type commands for breakpoint(s) 4, one per line.
End with a line saying just "end".
>continue
>end
(gdb) c
Continuing.
Breakpoint 1, update_frame (f=0xd3e808, force_p=false,
inhibit_hairy_id_p=false) at dispnew.c:3006
3006 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=-1, col=-1)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=0, col=0)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=1, col=0)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 1, update_frame (f=0xd3e808, force_p=true, inhibit_hairy_id_p=true)
at dispnew.c:3006
3006 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=2, col=0)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 1, update_frame (f=0xd3e808, force_p=true, inhibit_hairy_id_p=true)
at dispnew.c:3006
3006 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=3, col=0)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 1, update_frame (f=0xd3e808, force_p=true, inhibit_hairy_id_p=true)
at dispnew.c:3006
3006 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 2, update_frame_with_menu (f=0xd3e808, row=2, col=0)
at dispnew.c:3112
3112 struct window *root_window = XWINDOW (f->root_window);
Breakpoint 1, update_frame (f=0xd3e808, force_p=true, inhibit_hairy_id_p=true)
at dispnew.c:3006
3006 struct window *root_window = XWINDOW (f->root_window);
Explanations:
. first, a call to update_frame is because menu-bar-open calls
'redisplay'
. next, a call to update_frame_with_menu which comes from
the beginning of tty_menu_activate, line 3230 of term.c
. another call to update_frame_with_menu, to display the "File >"
header of the File menu.
. yet another call to update_frame_with_menu to display the first
menu item (Visit New File) in red background
. finally, a call to update_frame to display the help-echo for "Visit
New File"
Thereafter, for each keypress of an arrow key, there's always 1 call
to update_frame_with_menu, to display a different menu item in the red
background (see the values of row and col arguments, which identify
the menu item), followed by a single call to update_frame to display
the help echo.
Do you see any calls to update_frame beyond what I described? If so,
perhaps they are the reason the cursor gets back to the EOB of the
underlying buffer.
TIA
next prev parent reply other threads:[~2014-06-04 17:10 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83vbslbuqr.fsf@gnu.org>
[not found] ` <20140531200947.GA779@aerie.jexium-island.net>
[not found] ` <83lhtgbrd6.fsf@gnu.org>
[not found] ` <20140601152657.GA15078@aerie.jexium-island.net>
2014-06-01 16:25 ` bug#17497: 24.4.50; TTY menu glitches Eli Zaretskii
2014-06-01 17:12 ` Thomas Dickey
2014-06-01 17:18 ` Thomas Dickey
2014-06-01 18:45 ` Eli Zaretskii
2014-06-01 19:46 ` Thomas Dickey
2014-06-02 15:17 ` Eli Zaretskii
2014-06-02 16:14 ` Glenn Morris
2014-06-02 16:43 ` Eli Zaretskii
2014-06-02 16:46 ` Glenn Morris
2014-06-02 16:56 ` Eli Zaretskii
2014-06-02 17:05 ` Glenn Morris
2014-06-03 13:43 ` Stefan Monnier
2014-06-03 18:47 ` Thomas Dickey
2014-06-03 21:07 ` Eli Zaretskii
2014-06-03 22:21 ` Thomas Dickey
2014-06-04 6:54 ` Eli Zaretskii
2014-06-04 3:03 ` Stefan Monnier
2014-06-04 8:31 ` Thomas Dickey
2014-06-04 9:10 ` Thomas Dickey
2014-06-04 9:38 ` Eli Zaretskii
2014-06-04 10:16 ` Eli Zaretskii
2014-06-04 16:08 ` Glenn Morris
2014-06-04 16:15 ` Eli Zaretskii
2014-06-04 16:09 ` Glenn Morris
2014-06-04 16:23 ` Eli Zaretskii
2014-06-04 17:10 ` Eli Zaretskii [this message]
2014-06-04 13:06 ` Stefan Monnier
2014-06-04 20:26 ` Thomas Dickey
2014-06-05 0:47 ` Stefan Monnier
2014-06-05 8:21 ` Thomas Dickey
2014-06-05 8:29 ` Andreas Schwab
2014-06-05 15:02 ` Eli Zaretskii
2014-06-05 13:44 ` Stefan Monnier
2014-06-05 13:47 ` Stefan Monnier
2014-06-05 15:00 ` Eli Zaretskii
2014-06-01 18:39 ` Eli Zaretskii
2014-05-15 12:26 Dmitry Antipov
2014-05-15 17:37 ` Eli Zaretskii
2014-05-16 6:36 ` Glenn Morris
2014-05-16 6:38 ` Glenn Morris
2014-05-16 6:53 ` Glenn Morris
2014-05-16 8:48 ` Eli Zaretskii
2014-05-16 15:47 ` Glenn Morris
2014-05-16 20:21 ` Eli Zaretskii
2014-05-17 9:56 ` Eli Zaretskii
2014-05-22 2:49 ` Eli Zaretskii
2014-05-22 5:44 ` Glenn Morris
2014-05-22 7:51 ` Andreas Schwab
2014-05-22 15:58 ` Glenn Morris
2014-05-22 17:19 ` Andreas Schwab
2014-05-22 17:29 ` Glenn Morris
2014-05-22 17:53 ` Eli Zaretskii
2014-05-22 16:19 ` Eli Zaretskii
2014-05-22 16:26 ` Glenn Morris
2014-05-22 16:46 ` Eli Zaretskii
2014-05-30 9:22 ` Eli Zaretskii
2014-05-31 2:22 ` Glenn Morris
2014-05-31 8:20 ` Eli Zaretskii
2014-05-31 17:35 ` Glenn Morris
2014-06-01 15:11 ` Eli Zaretskii
2014-06-03 4:51 ` Glenn Morris
2014-06-03 7:03 ` Eli Zaretskii
2014-05-22 16:43 ` Eli Zaretskii
2014-05-22 16:54 ` Glenn Morris
2014-05-22 17:07 ` Eli Zaretskii
2014-05-16 9:42 ` Dmitry Antipov
2014-05-16 10:26 ` Eli Zaretskii
2014-05-16 10:46 ` Eli Zaretskii
2014-05-16 14:59 ` Dmitry Antipov
2014-05-16 15:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bnu87g85.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17497@debbugs.gnu.org \
--cc=dickey@his.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.