From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 17801-done@debbugs.gnu.org
Subject: bug#17801: 24.3.91; Regression: Texinfo Mode inserts newline after markup
Date: Fri, 20 Jun 2014 11:54:58 +0300 [thread overview]
Message-ID: <83bntorme5.fsf@gnu.org> (raw)
In-Reply-To: <jwv4mzgzyz2.fsf-monnier+emacsbugs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 17801@debbugs.gnu.org
> Date: Thu, 19 Jun 2014 11:44:22 -0400
>
> >> Indeed, there isn't any. But really skeleton shouldn't insert a newline
> >> by default (since it offers no way for individual skeletons to override
> >> it). Instead, each skeleton that needs it should end with a \n.
> > But this will probably cause massive breakage in users of skeleton.
>
> Indeed, that's why I haven't made such a change.
Should we make such a change on the trunk at this time?
> > For the branch, is it OK to make skeleton-end-newline buffer-local in
> > Texinfo buffers, and then give it a nil value?
>
> Yes.
Done as r117265 on the emacs-24 branch.
Btw, while working on this, I bumped into some strange feature: the
last \n element in a skeleton is only obeyed when it would be inserted
not at end of line. This is explicitly coded in skeleton.el:
;; \n as last element only inserts \n if not at eol.
((and (null (cdr skeleton-il)) (not recursive) (eolp))
For this reason, if a skeleton wants to always insert a newline at the
end, it quite embarrassingly must end with 2 \n elements, and risk
inserting an extra newline in some cases.
Is this a feature or a bug? If a feature, does the code assume that
skeleton-end-newline is non-nil? That is, should the condition
above also test skeleton-end-newline?
next prev parent reply other threads:[~2014-06-20 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:57 bug#17801: 24.3.91; Regression: Texinfo Mode inserts newline after markup Eli Zaretskii
2014-06-19 3:54 ` Stefan Monnier
2014-06-19 14:54 ` Eli Zaretskii
2014-06-19 15:44 ` Stefan Monnier
2014-06-20 8:54 ` Eli Zaretskii [this message]
2014-06-20 13:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bntorme5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17801-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.