From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Sat, 27 Sep 2014 10:05:19 +0300 Message-ID: <83bnq1tufk.fsf@gnu.org> References: <1532440199.73121411675536923.JavaMail.www@wwinf7125> <83wq8qu9bt.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1411801591 16777 80.91.229.3 (27 Sep 2014 07:06:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Sep 2014 07:06:31 +0000 (UTC) Cc: 18545@debbugs.gnu.org To: lompik@voila.fr Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 27 09:06:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XXm5H-00021d-77 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Sep 2014 09:06:23 +0200 Original-Received: from localhost ([::1]:54836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXm5E-0001nK-Bw for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Sep 2014 03:06:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXm56-0001n4-Le for bug-gnu-emacs@gnu.org; Sat, 27 Sep 2014 03:06:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXm51-0006ar-MI for bug-gnu-emacs@gnu.org; Sat, 27 Sep 2014 03:06:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXm51-0006Zr-J7 for bug-gnu-emacs@gnu.org; Sat, 27 Sep 2014 03:06:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XXm4w-0005TS-6B for bug-gnu-emacs@gnu.org; Sat, 27 Sep 2014 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Sep 2014 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141180154221014 (code B ref 18545); Sat, 27 Sep 2014 07:06:02 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 27 Sep 2014 07:05:42 +0000 Original-Received: from localhost ([127.0.0.1]:53457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXm4a-0005Sq-0N for submit@debbugs.gnu.org; Sat, 27 Sep 2014 03:05:40 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:33768) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXm4W-0005Sg-VE for 18545@debbugs.gnu.org; Sat, 27 Sep 2014 03:05:38 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NCJ00J00SJ47B00@mtaout29.012.net.il> for 18545@debbugs.gnu.org; Sat, 27 Sep 2014 10:05:01 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCJ00KGKT0CD200@mtaout29.012.net.il>; Sat, 27 Sep 2014 10:05:01 +0300 (IDT) In-reply-to: <83wq8qu9bt.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93787 Archived-At: > Date: Fri, 26 Sep 2014 10:31:18 +0300 > From: Eli Zaretskii > Cc: 18545@debbugs.gnu.org > > > Date: Thu, 25 Sep 2014 22:05:36 +0200 (CEST) > > From: lompik@voila.fr > > Cc: 18545@debbugs.gnu.org > > > > here's a related scrolling involving the lisp function recenter: > > > > 1. emacs -Q > > 2. define those binding: > > > > > > (global-set-key (kbd "C-`") '(lambda () > > (interactive) > > (with-selected-window (get-buffer-window "*Completions*") > > (forward-line 1)))) > > > > (global-set-key (kbd "C-~") '(lambda () > > (interactive) > > (with-selected-window (get-buffer-window "*Completions*") > > (forward-line -1)))) > > > > (global-set-key (kbd "C-;") '(lambda () > > (interactive) > > (with-selected-window (get-buffer-window "*Completions*") > > (recenter 5)))) > > > > 3. do: > > > > C-x C-f -> in a directory with lots of file. > > tab tab -> open completion buffer > > C-` -> to until scrolling down the *completion* buffer > > > > hit "C-;" -> nothing happens. it should recenter. > > hit "C-'`" -> it recenter then move one line down > > I'm not sure this is related to this bug. The problem here was that > the display engine was not considering for redisplay the window > showing the *Completions* buffer. The patch below fixes that. > > === modified file 'src/window.c' > --- src/window.c 2014-09-11 08:47:34 +0000 > +++ src/window.c 2014-09-26 07:28:02 +0000 > @@ -5897,6 +5897,8 @@ and redisplay normally--don't erase and > w->start_at_line_beg = (bytepos == BEGV_BYTE || > FETCH_BYTE (bytepos - 1) == '\n'); > > + wset_redisplay (w); > + > set_buffer_internal (obuf); > return Qnil; > } Does this fix the other problem which you saw with scrolling? (I doubt it does.) If so, could you please tell me how to reproduce that? Thanks.