From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20628: 25.0.50; Incorrect line height for some fonts Date: Fri, 29 May 2015 16:15:22 +0300 Message-ID: <83bnh3wmmt.fsf@gnu.org> References: <20150522.234959.238191883.wl@gnu.org> <556189D0.2000208@live.com> <83bnha1fxw.fsf@gnu.org> <20150524.113203.250674550.wl@gnu.org> <83617i1f29.fsf@gnu.org> <834mn21e7y.fsf@gnu.org> <83y4kaxd25.fsf@gnu.org> <83eglzx0as.fsf@gnu.org> <556824C6.1090909@live.com> <877frr3f3k.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1432906414 20670 80.91.229.3 (29 May 2015 13:33:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 May 2015 13:33:34 +0000 (UTC) Cc: clement.pitclaudel@live.com, 20628@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 29 15:33:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YyKPX-00065Z-Q3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 May 2015 15:33:19 +0200 Original-Received: from localhost ([::1]:35981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyKPS-0005Dx-5g for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 May 2015 09:33:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyK8r-0004GT-Qj for bug-gnu-emacs@gnu.org; Fri, 29 May 2015 09:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyK8o-0005yD-GC for bug-gnu-emacs@gnu.org; Fri, 29 May 2015 09:16:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyK8o-0005y9-E3 for bug-gnu-emacs@gnu.org; Fri, 29 May 2015 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YyK8o-0006IH-3Q for bug-gnu-emacs@gnu.org; Fri, 29 May 2015 09:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 May 2015 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20628-submit@debbugs.gnu.org id=B20628.143290534024164 (code B ref 20628); Fri, 29 May 2015 13:16:02 +0000 Original-Received: (at 20628) by debbugs.gnu.org; 29 May 2015 13:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:60106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YyK8Q-0006Hc-97 for submit@debbugs.gnu.org; Fri, 29 May 2015 09:15:39 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49603) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YyK8L-0006HH-LS for 20628@debbugs.gnu.org; Fri, 29 May 2015 09:15:36 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NP4000004MQM100@a-mtaout22.012.net.il> for 20628@debbugs.gnu.org; Fri, 29 May 2015 16:15:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NP4000F44TP4480@a-mtaout22.012.net.il>; Fri, 29 May 2015 16:15:26 +0300 (IDT) In-reply-to: <877frr3f3k.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103307 Archived-At: > From: Oleh Krehel > Cc: Eli Zaretskii , wl@gnu.org, 20628@debbugs.gnu.org > Date: Fri, 29 May 2015 11:30:55 +0200 > > Clément Pit--Claudel writes: > > > The patch partially solves the problem for me, but I noticed a few > > problems after running (set-frame-font "Latin Modern Math") > > * When the cursor is at the end of the file, on an empty line, it has a very height. ^^^^^^^^^^^ "Very WHAT height"? "very small" or "very large"? > > * The fix seems to only apply to certain characters. The line that I > > mentioned in my original email, in particular, is still very tall. In > > other words, when trying the following three lines in a Latin Modern > > Math buffer, the last line is much too tall: > > > > 𝓝 ;; This is still very tall I don't see this on my system. Here, it makes the line slightly higher, and that's all. Perhaps you have a different version of the font installed. But in any case, if that character still shows up as too large (a screenshot would be nice), and Emacs uses the Latin Modern Math font to display it (make sure with "C-u C-x ="), then there's nothing that can be done about that, since it means the metrics of the glyph itself, as reported by the font/font driver, are screwed. If you want to make sure that's the reason, put a breakpoint on line 26425 of xdisp.c, after the call to get_per_char_metric, as shown below: if (get_char_glyph_code (it->char_to_display, font, &char2b)) { pcm = get_per_char_metric (font, &char2b); if (pcm->width == 0 <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< && pcm->rbearing == 0 && pcm->lbearing == 0) pcm = NULL; } and see what ascent and descent values are reported for that character in pcm->ascent and pcm->descent. > Additionally, these chars are bad: \\|, λ. What do you mean by "bad"? Here, they just make the line slightly higher (by a few pixels), again due to the metrics of the glyphs, but nowhere near the original height before my changes. Isn't that what you see? > And all lines in Buffer-menu-mode are super-tall, just like the mode > line. That's because Buffer-menu-mode uses 'space' display property, which is another place where we use font dimensions. I will see if that can be fixed.