From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 20677@debbugs.gnu.org, angelo.graziosi@alice.it
Subject: bug#20677: tooltips generate garbage
Date: Tue, 02 Jun 2015 19:02:23 +0300 [thread overview]
Message-ID: <83bngyrtdc.fsf@gnu.org> (raw)
In-Reply-To: <876176qg7o.fsf@web.de>
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: Angelo Graziosi <angelo.graziosi@alice.it>, 20677@debbugs.gnu.org
> Date: Tue, 02 Jun 2015 17:31:55 +0200
>
> I see this problem, too. Quickly tested your questions with my
> configuration.
Thanks.
> > Does Emacs clean up the display if you type "M-x redraw-display RET"
> > after the tip pops down?
>
> Yes.
>
> > What about covering the frame with the tip artifacts with another
> > frame, then uncovering it -- does the frame get redrawn automatically,
> > and does that remove the artifacts?
>
> Yes, it does. Switching to another frame also removes the artifacts.
>
> > Finally, can you try setting x-gtk-use-system-tooltips to nil, and see
> > if that makes the problem go away?
>
> Yes, that helps.
OK, so it seems my guess was correct: we don't redraw the portions of
display that were obscured by the tooltip.
> Reverting 7927a4 as suggested somewhere else in this thread also fixes
> the problem for me.
I don't understand this. After reverting it, what does "git diff" say
about the differences between what you have and current master HEAD?
If it's just the diffs below (which is the reverse of what I see if I
type "git show 7927a4"), then how can the result work, when
x_clear_area now has this signature:
void x_clear_area (struct frame *f, int x, int y, int width, int height);
IOW, reverting 7927a4 seems to cause us call x_clear_area with a wrong
argument list. How does this even compile? What am I missing?
diff --git a/src/xfns.c b/src/xfns.c
index 5ac58e9..16a568e 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -1084,7 +1084,8 @@ struct x_display_info *
y = FRAME_TOP_MARGIN_HEIGHT (f);
block_input ();
- x_clear_area (f, 0, y, width, height);
+ x_clear_area (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+ 0, y, width, height);
unblock_input ();
}
@@ -1095,8 +1094,7 @@ struct x_display_info *
height = nlines * FRAME_LINE_HEIGHT (f) - y;
block_input ();
- x_clear_area (f, 0, y, width, height);
+ x_clear_area (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+ 0, y, width, height);
unblock_input ();
}
next prev parent reply other threads:[~2015-06-02 16:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:40 bug#20677: tooltips generate garbage Angelo Graziosi
2015-05-28 2:43 ` Eli Zaretskii
2015-06-01 11:46 ` Angelo Graziosi
2015-06-01 14:36 ` Eli Zaretskii
2015-06-01 15:58 ` Angelo Graziosi
2015-06-01 16:19 ` Eli Zaretskii
2015-06-01 21:55 ` Angelo Graziosi
2015-06-02 2:33 ` Eli Zaretskii
2015-06-02 9:23 ` Angelo Graziosi
2015-06-02 9:35 ` Angelo Graziosi
2015-06-02 14:57 ` Eli Zaretskii
2015-06-02 15:31 ` Michael Heerdegen
2015-06-02 15:39 ` Michael Heerdegen
2015-06-02 15:54 ` Michael Heerdegen
2015-06-02 16:16 ` Eli Zaretskii
2015-06-02 16:33 ` Michael Heerdegen
2015-06-02 19:08 ` Eli Zaretskii
2015-06-03 7:01 ` YAMAMOTO Mitsuharu
2015-06-03 13:51 ` Angelo Graziosi
2015-06-03 16:10 ` Michael Heerdegen
2015-06-03 16:43 ` Eli Zaretskii
2015-06-03 17:02 ` Michael Heerdegen
2015-06-03 19:14 ` Eli Zaretskii
2015-06-04 5:25 ` YAMAMOTO Mitsuharu
2015-06-04 15:37 ` Eli Zaretskii
2015-06-05 0:50 ` YAMAMOTO Mitsuharu
2015-06-05 7:04 ` Eli Zaretskii
2015-06-02 17:06 ` Michael Heerdegen
2015-06-02 17:08 ` Wolfgang Jenkner
2015-06-02 16:02 ` Eli Zaretskii [this message]
2015-06-02 16:14 ` Michael Heerdegen
2015-06-02 17:04 ` Angelo Graziosi
2015-06-02 18:56 ` Eli Zaretskii
2015-06-02 0:31 ` Wolfgang Jenkner
2015-06-02 9:21 ` Angelo Graziosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bngyrtdc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20677@debbugs.gnu.org \
--cc=angelo.graziosi@alice.it \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.