From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20734: 25.0.50; "Args out of range" with help-window-select t Date: Fri, 05 Jun 2015 16:45:32 +0300 Message-ID: <83bngup8ub.fsf@gnu.org> References: <86vbf3tfwj.fsf@members.fsf.org> <83r3pqpsh0.fsf@gnu.org> <867fritskw.fsf@members.fsf.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1433512042 5654 80.91.229.3 (5 Jun 2015 13:47:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jun 2015 13:47:22 +0000 (UTC) Cc: 20734@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 05 15:47:06 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z0rxd-0003fB-5q for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 15:47:01 +0200 Original-Received: from localhost ([::1]:47423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0rxc-0008HW-C2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 09:47:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0rwn-0007We-Pa for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 09:46:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0rwi-0001aE-F5 for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 09:46:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0rwi-0001aA-0l for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 09:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z0rwh-0003fv-7i for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 09:46:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 13:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20734-submit@debbugs.gnu.org id=B20734.143351195314111 (code B ref 20734); Fri, 05 Jun 2015 13:46:03 +0000 Original-Received: (at 20734) by debbugs.gnu.org; 5 Jun 2015 13:45:53 +0000 Original-Received: from localhost ([127.0.0.1]:41269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0rwW-0003fW-Gn for submit@debbugs.gnu.org; Fri, 05 Jun 2015 09:45:53 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46211) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0rwS-0003fF-Vt for 20734@debbugs.gnu.org; Fri, 05 Jun 2015 09:45:49 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NPH006004V1II00@a-mtaout20.012.net.il> for 20734@debbugs.gnu.org; Fri, 05 Jun 2015 16:45:35 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPH0066J4VZ9S70@a-mtaout20.012.net.il>; Fri, 05 Jun 2015 16:45:35 +0300 (IDT) In-reply-to: <867fritskw.fsf@members.fsf.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103612 Archived-At: > From: Nicolas Richard > Cc: 20734@debbugs.gnu.org > Date: Fri, 05 Jun 2015 11:25:35 +0200 > > 1. run under gdb > 2. follow the recipe up to the point where I type "C-h f if", but don't > hit RET > 3. then go to gdb window > 4. hit C-z to put a breakpoint in adjust_point_for_property > 5. continue > 6. go back to emacs and hit RET > > Now back to gdb : > (gdb) p XBUFFER(XWINDOW(selected_window)->contents)->name_ > $1 = 143880388 > (gdb) xpr > Lisp_String > $2 = (struct Lisp_String *) 0x89370c0 > "*Help*" You could also do this, which is slightly easier: (gdb) p XWINDOW(selected_window)->contents (gdb) xtype # make sure it's a buffer (gdb) xbuffer > > And please note that the conditions in the 'if' clause that determine > > whether adjust_point_for_property is called freely manipulate values > > of current_buffer and PT, so perhaps the solution is add there a > > condition that selected_window's buffer and current_buffer are equal, > > such that in the case in point adjust_point_for_property is not called > > at all. > > In command_loop_1 ? Yes. > I can more or less follow the code step by step, but I don't really > understand it. The only thing I'm now almost 100% confident is that in > this call (found in adjust_point_for_property) : > get_char_property_and_overlay > (make_number (PT), Qdisplay, selected_window, > &overlay)) > PT refers to current_buffer, which is different from the buffer in > selected_window in the situation I encountered. Yes, that's the bug. But the real problem is that we've switched windows temporarily, and we shouldn't move point in the current buffer at all when we do that. > > To answer your question directly, it should be possible to compute the > > (Lisp integer) value of point in the selected window as either > > Thanks. This works for me, but is it TRT ? No, I think we shouldn't call adjust_point_for_property in this case at all. Can you see if adding && EQ (XWINDOW (selected_window)->contents, current_buffer) to the condition that guards the call to adjust_point_for_property fixes the problem? I.e., instead of this (after the label 'finalize'): if (current_buffer == prev_buffer && last_point_position != PT && NILP (Vdisable_point_adjustment) && NILP (Vglobal_disable_point_adjustment)) the condition should read if (current_buffer == prev_buffer && EQ (XWINDOW (selected_window)->contents, current_buffer) && last_point_position != PT && NILP (Vdisable_point_adjustment) && NILP (Vglobal_disable_point_adjustment)) IOW, if the selected window's buffer is not the current buffer, we shouldn't be adjusting point in the current buffer at all. Thanks.