From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: tobias.getzner@gmx.de, 20802@debbugs.gnu.org
Subject: bug#20802: Segfault when showing non-GTK+ tooltip
Date: Thu, 18 Jun 2015 18:53:39 +0300 [thread overview]
Message-ID: <83bngdko70.fsf@gnu.org> (raw)
In-Reply-To: <5582C990.5020009@gmx.at>
> Date: Thu, 18 Jun 2015 15:37:20 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: tobias.getzner@gmx.de, 20802@debbugs.gnu.org
>
> > Why can't we simply move the code that frees the image cache to
> > delete_terminal? There's only one image cache for each terminal, and
> > it's shared by all frames on that terminal, right? And we call
> > delete-terminal when we delete the last frame on the terminal, right?
>
> ‘delete-terminal’ can run into precisely the same problem I described in
> my previous scenario. IMHO we have to give up the idea of using
> refcounts to tell whether a frame might still use some object - they are
> not up to this task.
These are 2 different issues.
Do you agree that there's no need to decide whether we should free the
image cache while deleting a frame, and instead do that when we delete
a terminal? If you agree, we should move the code that frees the
image cache there.
If, in addition, you are saying that we will sometimes delete a
terminal when it still has live frames, then we could simply count the
frames on a terminal instead of using a refcount. Something like this
(we already have similar code in delete_frame):
count = 0;
FOR_EACH_FRAME (tail, frame1)
if (FRAME_TERMINAL (XFRAME (frame)) == FRAME_TERMINAL (XFRAME (frame1)))
count++;
next prev parent reply other threads:[~2015-06-18 15:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-13 9:18 bug#20802: Segfault when showing non-GTK+ tooltip Tobias Getzner
2015-06-13 9:38 ` Eli Zaretskii
2015-06-13 10:25 ` martin rudalics
2015-06-13 10:54 ` Eli Zaretskii
2015-06-13 13:24 ` martin rudalics
2015-06-13 14:01 ` Eli Zaretskii
2015-06-13 14:28 ` martin rudalics
2015-06-13 14:42 ` Eli Zaretskii
2015-06-14 11:00 ` martin rudalics
2015-06-14 14:12 ` Eli Zaretskii
2015-06-15 8:22 ` martin rudalics
2015-06-15 15:01 ` Eli Zaretskii
2015-06-15 16:00 ` martin rudalics
2015-06-15 17:29 ` Eli Zaretskii
2015-06-16 13:30 ` martin rudalics
2015-06-16 14:54 ` Eli Zaretskii
2015-06-17 9:36 ` martin rudalics
2015-06-17 16:39 ` Eli Zaretskii
2015-06-17 18:56 ` Stefan Monnier
2015-06-18 13:37 ` martin rudalics
2015-06-18 15:53 ` Eli Zaretskii [this message]
2015-06-18 16:48 ` martin rudalics
2015-06-18 17:17 ` Eli Zaretskii
2015-06-18 17:36 ` martin rudalics
2015-06-18 18:00 ` Eli Zaretskii
2015-06-19 6:43 ` martin rudalics
2022-04-29 11:45 ` Lars Ingebrigtsen
2022-05-28 10:58 ` Lars Ingebrigtsen
2015-06-16 7:21 ` Tobias Getzner
2015-06-16 13:30 ` martin rudalics
2015-06-16 15:34 ` Tobias Getzner
2015-06-16 15:58 ` Eli Zaretskii
2015-06-16 16:34 ` Tobias Getzner
2015-06-16 17:12 ` Eli Zaretskii
2015-06-16 17:31 ` martin rudalics
2015-06-17 7:34 ` Tobias Getzner
2015-06-17 8:04 ` martin rudalics
2015-06-17 14:11 ` Tobias Getzner
2015-06-18 13:37 ` martin rudalics
2015-06-18 14:09 ` Tobias Getzner
2015-06-17 16:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bngdko70.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20802@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=tobias.getzner@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.