From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xdisp.c's struct it questions. Date: Sun, 04 Oct 2015 20:04:14 +0300 Message-ID: <83bnce1s6p.fsf@gnu.org> References: <20151003154835.GA4509@acm.fritz.box> <83r3lc2au2.fsf@gnu.org> <20151004134431.GA22632@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443978279 19033 80.91.229.3 (4 Oct 2015 17:04:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Oct 2015 17:04:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 04 19:04:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zimi4-0008Bz-L1 for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 19:04:28 +0200 Original-Received: from localhost ([::1]:43124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zimi4-0001CK-0h for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 13:04:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zimhy-0001BK-Iw for emacs-devel@gnu.org; Sun, 04 Oct 2015 13:04:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zimhu-0000nd-JJ for emacs-devel@gnu.org; Sun, 04 Oct 2015 13:04:22 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:38369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zimhu-0000nE-By for emacs-devel@gnu.org; Sun, 04 Oct 2015 13:04:18 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NVP00700GILNM00@mtaout25.012.net.il> for emacs-devel@gnu.org; Sun, 04 Oct 2015 20:01:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVP0068EGMO9A20@mtaout25.012.net.il>; Sun, 04 Oct 2015 20:01:36 +0300 (IDT) In-reply-to: <20151004134431.GA22632@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190891 Archived-At: > Date: Sun, 4 Oct 2015 13:44:31 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > The biggest time sink for me at the moment is the vagueness in xdisp.c's > use of the word "line". Sometimes it means a screen line, sometimes it > means a text line. Yes, that's true. The reason is the desire to keep identifier names shorter, I guess. > An example is `forward_to_next_line_start'. It sounds like just what I > need, but is it? If it were called `forward_to_next_screen_line_start', > or `forward_to_next_text_line_start', I could save myself an awful lot > of poring through source code. All the forward_to_*_line and back_to_*_line functions mean physical lines. If you need to move to the next screen line, you need to call move_it_to instead. > Even the comments preceding these routines tend to be vague about > this. The comments mention a newline, which is a clear sign they mean a physical line.