From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: xdisp.c's struct it questions.
Date: Sun, 04 Oct 2015 20:04:14 +0300 [thread overview]
Message-ID: <83bnce1s6p.fsf@gnu.org> (raw)
In-Reply-To: <20151004134431.GA22632@acm.fritz.box>
> Date: Sun, 4 Oct 2015 13:44:31 +0000
> Cc: emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
>
> The biggest time sink for me at the moment is the vagueness in xdisp.c's
> use of the word "line". Sometimes it means a screen line, sometimes it
> means a text line.
Yes, that's true. The reason is the desire to keep identifier names
shorter, I guess.
> An example is `forward_to_next_line_start'. It sounds like just what I
> need, but is it? If it were called `forward_to_next_screen_line_start',
> or `forward_to_next_text_line_start', I could save myself an awful lot
> of poring through source code.
All the forward_to_*_line and back_to_*_line functions mean physical
lines.
If you need to move to the next screen line, you need to call
move_it_to instead.
> Even the comments preceding these routines tend to be vague about
> this.
The comments mention a newline, which is a clear sign they mean a
physical line.
prev parent reply other threads:[~2015-10-04 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 15:48 xdisp.c's struct it questions Alan Mackenzie
2015-10-03 16:06 ` Andreas Schwab
2015-10-03 16:09 ` Eli Zaretskii
2015-10-03 16:38 ` Alan Mackenzie
2015-10-03 16:59 ` Eli Zaretskii
2015-10-04 13:44 ` Alan Mackenzie
2015-10-04 17:04 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bnce1s6p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.