bug#21685: 25.0.50; [NS] Images not loading

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 20 Oct 2015 09:35:21 -0600
> From: Ivan Andrus <darthandrus@gmail.com>
> 
> On Mon, Oct 19, 2015 at 7:17 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> From: Ivan Andrus <darthandrus@gmail.com>
> >> Date: Wed, 14 Oct 2015 23:09:28 -0600
> >> Cc: 21685@debbugs.gnu.org
> >>
> >> > On Oct 14, 2015, at 8:39 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> >
> >> >> Date: Wed, 14 Oct 2015 14:43:51 -0600
> >> >> From: Ivan Andrus <darthandrus@gmail.com>
> >> >>
> >> >> Reading openp, I'm confused.  The documentation says it returns -2
> >> >> if the file is remote, but it seems to actually be checking if
> >> >> `find-file-name-handler' returns non-nil.  In particular, images
> >> >> return `image-file-handler', so at the very least the documentation
> >> >> seems wrong.
> >> >
> >> > The practical meaning of "remote" in Emacs means exactly that: the
> >> > file name has a non-nil handler.  So the documentation is not wrong,
> >> > just confusing if you don't keep this definition in mind.
> >> >
> >> > (I'm not saying that the above explains or invalidates your bug
> >> > report.)
> >>
> >> I bisected and indeed 636736861688abe73cc5dd4181fdb66de3fd8cfd is the
> >> first bad commit.
> >>
> >> However, I also noticed that emacs -Q does not exhibit the problem
> >> because file-name-handler-alist does not have an entry for images.  So I
> >> must be loading some package whichs adds a handler for images.  In fact,
> >> if I turn off auto-image-file-mode, images appear as I expect.
> >
> > OK, thanks for the detailed analysis.  I think I fixed this on master,
> > please try.
> 
> And thank you for fixing it!  I tried to create a patch, but failed entirely.
> 
> Your commit has fixed the problem for me in every case that I have tried so far.

OK, thanks for testing.  I'm therefore marking this bug done.