From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21699: 24.5; Bug in backup-buffer-copy and/or set-file-extended-attributes etc [set-file-extended-attributes] Date: Fri, 23 Oct 2015 11:25:45 +0300 Message-ID: <83bnbqrnxy.fsf@gnu.org> References: <831tcricrz.fsf@gnu.org> <83zizfgxnl.fsf@gnu.org> <83wpujgwr3.fsf@gnu.org> <83si57gu7s.fsf@gnu.org> <83k2qjgqm5.fsf@gnu.org> <83fv17go6s.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445588861 20275 80.91.229.3 (23 Oct 2015 08:27:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 08:27:41 +0000 (UTC) Cc: 21699@debbugs.gnu.org To: Eli Barzilay , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 23 10:27:28 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpXgt-0000B0-Dj for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 10:27:11 +0200 Original-Received: from localhost ([::1]:36967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXgs-0002cQ-UI for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 04:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXgp-0002cK-7Q for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpXgl-00015r-50 for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:27:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpXgk-00015n-W3 for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZpXgk-0000yt-Hg for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 04:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2015 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21699-submit@debbugs.gnu.org id=B21699.14455887933736 (code B ref 21699); Fri, 23 Oct 2015 08:27:02 +0000 Original-Received: (at 21699) by debbugs.gnu.org; 23 Oct 2015 08:26:33 +0000 Original-Received: from localhost ([127.0.0.1]:33745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpXgG-0000yB-DU for submit@debbugs.gnu.org; Fri, 23 Oct 2015 04:26:32 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:49855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpXfv-0000xY-GO for 21699@debbugs.gnu.org; Fri, 23 Oct 2015 04:26:30 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NWN00100Z65HQ00@mtaout29.012.net.il> for 21699@debbugs.gnu.org; Fri, 23 Oct 2015 11:25:04 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWN00NX0ZDSXX30@mtaout29.012.net.il>; Fri, 23 Oct 2015 11:25:04 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107895 Archived-At: > Date: Thu, 22 Oct 2015 01:43:35 -0400 > From: Eli Barzilay > Cc: 21699@debbugs.gnu.org > > On Mon, Oct 19, 2015 at 6:14 AM, Eli Zaretskii wrote: > > > > Thanks. I'll let others to express opinions on this alternative vs > > the one I committed. The difference is what happens when all the > > attribute values are "null" values: your version returns t in that > > case, and I'm not sure that's correct, see below. > > Ah, you're talking about this code from `backup-buffer-copy': > > (unless (and extended-attributes > (with-demoted-errors > (set-file-extended-attributes to-name extended-attributes))) > ...) > > In that case, I think that my slightly earlier fix which made > `file-extended-attributes' drop "null" values is actually fine: it means > that in the above snipped `extended-attributes' will be nil, and the > chmod code will run. There is another use of a similar pattern (look > for an "If set-file-extended-attributes fails" comment which appears in > both places) where this second one should also have the same `and'. > > (The current state is messy anyway, since with your current fix, the > `and' in the above is not needed, and anyway, `extended-attributes' is > never nil.) > > FWIW, there is no real loss of information for doing that: > `extended-attributes' currently adds acl and selinux entries always, > with my fix (of dropping the no-info values) you can tell when there was > no information for acl/selinux just by the fact that there is no such > element in the `extended-attributes' result. Paul (or anyone else), any second opinions about this? Thanks.