From: Eli Zaretskii <eliz@gnu.org>
To: Eli Barzilay <eli@barzilay.org>, Paul Eggert <eggert@cs.ucla.edu>
Cc: 21699@debbugs.gnu.org
Subject: bug#21699: 24.5; Bug in backup-buffer-copy and/or set-file-extended-attributes etc [set-file-extended-attributes]
Date: Fri, 23 Oct 2015 11:25:45 +0300 [thread overview]
Message-ID: <83bnbqrnxy.fsf@gnu.org> (raw)
In-Reply-To: <CALO-gusgjpQw+bctwWVMwWSYfZyn1h+yRoiaxfOZvjQqSkh8gw@mail.gmail.com>
> Date: Thu, 22 Oct 2015 01:43:35 -0400
> From: Eli Barzilay <eli@barzilay.org>
> Cc: 21699@debbugs.gnu.org
>
> On Mon, Oct 19, 2015 at 6:14 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Thanks. I'll let others to express opinions on this alternative vs
> > the one I committed. The difference is what happens when all the
> > attribute values are "null" values: your version returns t in that
> > case, and I'm not sure that's correct, see below.
>
> Ah, you're talking about this code from `backup-buffer-copy':
>
> (unless (and extended-attributes
> (with-demoted-errors
> (set-file-extended-attributes to-name extended-attributes)))
> ...)
>
> In that case, I think that my slightly earlier fix which made
> `file-extended-attributes' drop "null" values is actually fine: it means
> that in the above snipped `extended-attributes' will be nil, and the
> chmod code will run. There is another use of a similar pattern (look
> for an "If set-file-extended-attributes fails" comment which appears in
> both places) where this second one should also have the same `and'.
>
> (The current state is messy anyway, since with your current fix, the
> `and' in the above is not needed, and anyway, `extended-attributes' is
> never nil.)
>
> FWIW, there is no real loss of information for doing that:
> `extended-attributes' currently adds acl and selinux entries always,
> with my fix (of dropping the no-info values) you can tell when there was
> no information for acl/selinux just by the fact that there is no such
> element in the `extended-attributes' result.
Paul (or anyone else), any second opinions about this?
Thanks.
next prev parent reply other threads:[~2015-10-23 8:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 4:34 bug#21699: 24.5; Bug in backup-buffer-copy and/or set-file-extended-attributes etc Eli Barzilay
2015-10-18 16:01 ` Eli Zaretskii
2015-10-18 21:05 ` Eli Barzilay
2015-10-19 5:10 ` Eli Zaretskii
2015-10-19 7:57 ` Eli Barzilay
2015-10-19 8:23 ` Eli Zaretskii
2015-10-19 9:03 ` Eli Barzilay
2015-10-19 9:09 ` Eli Zaretskii
2015-10-19 9:14 ` Eli Barzilay
2015-10-19 6:14 ` bug#21699: 24.5; Bug in backup-buffer-copy and/or set-file-extended-attributes etc [set-file-extended-attributes] Eli Barzilay
2015-10-19 6:38 ` Eli Zaretskii
2015-10-19 6:50 ` Eli Zaretskii
2015-10-19 7:09 ` Eli Zaretskii
2015-10-19 7:50 ` Eli Barzilay
2015-10-19 8:04 ` Eli Zaretskii
2015-10-19 9:10 ` Eli Barzilay
2015-10-19 9:22 ` Eli Zaretskii
2015-10-19 9:47 ` Eli Barzilay
2015-10-19 10:14 ` Eli Zaretskii
2015-10-22 5:43 ` Eli Barzilay
2015-10-23 8:25 ` Eli Zaretskii [this message]
2022-04-22 13:27 ` bug#21699: 24.5; Bug in backup-buffer-copy and/or set-file-extended-attributes etc Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bnbqrnxy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21699@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eli@barzilay.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.