From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22250: 25.0.50; Eww fails to break RTL paragraph Date: Mon, 28 Dec 2015 19:12:00 +0200 Message-ID: <83bn9afqfz.fsf@gnu.org> References: <8760zj3dvr.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> <83twn3g0ac.fsf@gnu.org> <8760zjbi9s.fsf@justinian.turtle-trading.net> <83k2nzfdt9.fsf@gnu.org> <87twn2il10.fsf@justinian.turtle-trading.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1451323722 32112 80.91.229.3 (28 Dec 2015 17:28:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 17:28:42 +0000 (UTC) Cc: 22250@debbugs.gnu.org, larsi@gnus.org To: Benjamin Riefenstahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 18:28:29 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDbav-0001DD-5L for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 18:28:29 +0100 Original-Received: from localhost ([::1]:45561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbau-0005LR-NK for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 12:28:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbL4-0001Kd-NK for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:12:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDbL0-00026L-0S for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:12:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbKz-00026H-TV for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:12:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDbKz-0005Dp-OM for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 17:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 22250-submit@debbugs.gnu.org id=B22250.145132269620038 (code B ref 22250); Mon, 28 Dec 2015 17:12:01 +0000 Original-Received: (at 22250) by debbugs.gnu.org; 28 Dec 2015 17:11:36 +0000 Original-Received: from localhost ([127.0.0.1]:46615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbKY-0005D4-W7 for submit@debbugs.gnu.org; Mon, 28 Dec 2015 12:11:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46581) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbKU-0005Cp-Lc for 22250@debbugs.gnu.org; Mon, 28 Dec 2015 12:11:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDbKL-00022C-3N for 22250@debbugs.gnu.org; Mon, 28 Dec 2015 12:11:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbK9-000211-Da; Mon, 28 Dec 2015 12:11:09 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3909 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aDbK8-0004Jh-Hk; Mon, 28 Dec 2015 12:11:08 -0500 In-reply-to: <87twn2il10.fsf@justinian.turtle-trading.net> (message from Benjamin Riefenstahl on Mon, 28 Dec 2015 17:40:43 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110898 Archived-At: > From: Benjamin Riefenstahl > Cc: 22250@debbugs.gnu.org, larsi@gnus.org > Date: Mon, 28 Dec 2015 17:40:43 +0100 > > Eli Zaretskii writes: > > Does the patch below fix the problem? > > Sorry, no, no change here with that. ??? It certainly solved the problem with your original HTML file visited with eww-open-file. Doesn't it solve that for you? Are you sure you tested correctly? And what exactly did you test? > I looked at the code though and I noticed the call stack > > shr-fill-line > -> shr-vertical-motion > -> vertical-motion > > which is used to find the line break point. It seems the idea here is > that Emacs' normal line wrap is used, we just go one line down, and > vertical-motion gets us to the place where Emacs has wrapped. No, that's not how this works, AFAIK. (But Lars can correct me if I'm wrong.) What it does is go to the column where it wants to wrap and then checks if it's at EOL. If not, it goes back and looks for a place to insert a newline. Rinse, repeat. > I'm wondering why this bug depends on RTL layout. I'm wondering why it happens at all, after the patch I sent. When bidi-display-reordering is set to nil, there is no RTL layout, any text is laid out in strict logical left-to-right order. > I tried my test case without dir=rtl and with "abc" as text, but > that works fine, so RTL really is a factor. It cannot be, not when bidi-display-reordering is bound to nil. Something else is at work there. > If I narrow my Emacs window here, it breaks like this, though: > > aaa bbb בבב > אאא > > So there seems to be an even bigger issue in Emacs generally? No, this is the bidi display engine working as designed. > At least Emacs default wrapping behaviour seems not directly usable > as a basis for filling paragraphs correctly. shr doesn't use the wrapping behavior, it does its own layout calculations.