From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23076: 24.5; vc-git: add a new variable for log output coding system Date: Sat, 09 Apr 2016 17:48:13 +0300 Message-ID: <83bn5ij0sy.fsf@gnu.org> References: <56EFE033.7080900@gmail.com> <56F04527.6010901@gmail.com> <83fuv4s4cr.fsf@gnu.org> <57017E45.7050605@gmail.com> <83pou5o0uh.fsf@gnu.org> <5708F5CA.3080509@gmail.com> <83egafhrpf.fsf@gnu.org> <57090E2F.4020702@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460213418 22879 80.91.229.3 (9 Apr 2016 14:50:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2016 14:50:18 +0000 (UTC) Cc: 23076@debbugs.gnu.org To: Nikolay Kudryavtsev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 09 16:50:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aouDE-0007XB-RX for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 16:50:12 +0200 Original-Received: from localhost ([::1]:60562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aouDE-0005ic-6x for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 10:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aouD9-0005dZ-10 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 10:50:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aouD4-0003NX-Ap for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 10:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aouD4-0003NS-7H for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 10:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aouD4-0007Tm-2E for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 10:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2016 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23076-submit@debbugs.gnu.org id=B23076.146021334328675 (code B ref 23076); Sat, 09 Apr 2016 14:50:02 +0000 Original-Received: (at 23076) by debbugs.gnu.org; 9 Apr 2016 14:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:56196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aouC7-0007SR-5r for submit@debbugs.gnu.org; Sat, 09 Apr 2016 10:49:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aouC4-0007Rt-OA for 23076@debbugs.gnu.org; Sat, 09 Apr 2016 10:49:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aouBv-0003Jf-30 for 23076@debbugs.gnu.org; Sat, 09 Apr 2016 10:48:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aouBu-0003Jb-Vv; Sat, 09 Apr 2016 10:48:51 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aouBu-0006I3-Ay; Sat, 09 Apr 2016 10:48:50 -0400 In-reply-to: <57090E2F.4020702@gmail.com> (message from Nikolay Kudryavtsev on Sat, 9 Apr 2016 17:14:07 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116277 Archived-At: > From: Nikolay Kudryavtsev > Cc: 23076@debbugs.gnu.org > Date: Sat, 9 Apr 2016 17:14:07 +0300 > > > How can it break someone's setup, if using the current system codepage > > is the_only_ way of invoking programs from Emacs on MS-Windows? > Download this: > https://github.com/msysgit/msysgit/releases/download/Git-1.7.9-preview20120201/PortableGit-1.7.9-preview20120201.7z > Then, from emacs -Q: > (setq vc-git-program "d:/Downloads/PortableGit/bin/git.exe") > Note that the git is used from bin, and not from cmd. Russian commits do > work with this version, when vc-git-commits-coding system is utf-8. This cannot work except by accident, and/or for only some specific characters. Windows attempts to translate non-ASCII characters passed to programs to the current codepage, so a byte that is not possible in the codepage will be mangled. For example, try a log message that uses a UTF-8 string which has a 0x98 byte in it -- the only byte that is not a valid cp1251 character -- you will see it mangled on the Git side. > So we can define breaking someone's setup - if that someone uses this > old git version, forcing windows-1251 would break his setup. > 1.7.9 is the last working version. Even if I'm wrong about this, v1.7.9 is too old to care about. It's too easy to upgrade. > In the end, of course I like solution #2. Thanks, I will work on implementing it.